Summary: | handle Solaris/SVR4 manpages (with long section names) and keyword index | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kio | Reporter: | Jonathan Marten <jjm> |
Component: | man | Assignee: | Niek van den Berg <niek.vandenberg> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Other | ||
Latest Commit: | Version Fixed In: |
Description
Jonathan Marten
2002-07-16 14:46:48 UTC
looks good, will check that later. Coolo? Do you approve of that patch? :) Subject: Re: handle Solaris/SVR4 manpages (with long section names) and keyword index On Samstag, 22. Februar 2003 10:07, you wrote: > ------- You are receiving this mail because: ------- > You are the assignee for the bug, or are watching the assignee. > > http://bugs.kde.org/show_bug.cgi?id=45309 > > > > > ------- Additional Comments From staikos@kde.org 2003-02-22 10:07 ------- > Coolo? Do you approve of that patch? :) Well, if you check the patch, you'll notice that it misses commas. And the code has changed too much so it's real work. But the bug is still ASSIGNED Greetings, Stephan We did discuss the patch on kde-devel some time ago. The consensus was that since it was a complex change, the patch had been badly mangled by the bug database, and also someone else had submitted some other changes to the same area, this bug would be put aside and I'd look at reimplementing the fixes if necessary once KDE3.1 was out (I suppose that means now). So I'd be happy if this bug was closed as will-not-fix. Subject: Re: handle Solaris/SVR4 manpages (with long section names) and keyword index
Am Monday 24 February 2003 10:28 schrieben Sie:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=45309
>
>
>
>
> ------- Additional Comments From jonathan.marten@uk.sun.com 2003-02-24 10:28 -------
> We did discuss the patch on kde-devel some time ago. The consensus was that since it was a
> complex change, the patch had been badly mangled by the bug database, and also someone else
> had submitted some other changes to the same area, this bug would be put aside and I'd look at
> reimplementing the fixes if necessary once KDE3.1 was out (I suppose that means now).
>
> So I'd be happy if this bug was closed as will-not-fix.
>
I leave it open as reminder :)
Gruss, Stephan
Jonathan, any news? I don't remember any. Updated long section names patch provided in bug 74925. Other fixes in this patch are either already implemented or would be impossible to patch into current sources. Suggest this bug is closed as WONTFIX. *** Bug 74925 has been marked as a duplicate of this bug. *** CVS commit by coolo: applying fix for 74925 CCMAIL: 45309-done@bugs.kde.org M +19 -4 man2html.cpp 1.41.2.1 --- kdebase/kioslave/man/man2html.cpp #1.41:1.41.2.1 @@ -620,4 +620,5 @@ static void add_links(char *c) char *f, *g,*h; char *idtest[6]; /* url, mailto, www, ftp, manpage */ + bool ok; out_length+=strlen(c); /* search for (section) */ @@ -683,8 +684,22 @@ static void add_links(char *c) /* check section */ g=strchr(f,')'); - if (g && f-g<6 && (isalnum(f[-1]) || f[-1]=='>') && - ((isdigit(f[1]) && f[1]!='0' && - (f[2]==')' || (isalpha(f[2]) && f[3]==')') || f[2]=='X')) || - (f[2]==')' && (f[1]=='n' || f[1]=='l')))) { + if (g!=NULL && (g-f)<12 && (isalnum(f[-1]) || f[-1]=='>') && + isdigit(f[1]) && f[1]!='0') + { + ok = TRUE; + h = f+2; + while (h<g) + { + if (!isalpha(*h++)) + { + ok = FALSE; + break; + } + } + } + else ok = FALSE; + + if (ok) + { /* this might be a link */ h=f-1; |