| Summary: | Knotify and Network Audio System | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kdelibs | Reporter: | Escuder Nicolas <n.escuder> |
| Component: | knotify | Assignee: | Carsten Pfeiffer <pfeiffer> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Other | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Change deviceName from "null" to "NAS" | ||
Created attachment 277 [details]
Change deviceName from "null" to "NAS"
This patch is neither tested nor do I know what I'm doing here (just guessing
:)
kde-multimedia, please help.
Subject: arts/flow
CVS commit by pfeiffer:
- paramStr(deviceName) = "null";
+ paramStr(deviceName) = "NAS";
param(fragmentSize) = 1024;
param(fragmentCount) = 7;
param(format) = 16;
@@ -150,7 +150,7 @@ bool AudioIONAS::open()
return false;
}
- aud = AuOpenServer(_device.compare("null") == 0
+ aud = AuOpenServer(_device.compare("NAS") == 0
CCMAIL: 44370-close@bugs.kde.org
M +2 -2 audioionas.cc 1.3
Subject: Re: Knotify and Network Audio System Oh no !!! not this patch i try do it before ... it crash Sound preview and sound listen in Konqueror :(((( The only patch how work fine and don't crash anything is to ignore null in knotify :( Sorry for this longer answer i just have your message today and see you change the status today :(( Revert the change or the audio for nas will be broken expecting knotify :o))))))) see you Nicolas. ----- Original Message ----- From: "Carsten Pfeiffer" <pfeiffer@kde.org> To: <n.escuder@alineanet.com> Sent: Saturday, October 26, 2002 9:52 PM Subject: [Bug 44370] Knotify and Network Audio System > ------- You are receiving this mail because: ------- > You reported the bug, or are watching the reporter. > > http://bugs.kde.org/show_bug.cgi?id=44370 > > > > > ------- Additional Comments From pfeiffer@kde.org 2002-10-26 22:52 ------- > Created an attachment (id=277) > --> (http://bugs.kde.org/attachment.cgi?id=277&action=view) > Change deviceName from "null" to "NAS" > > This patch is neither tested nor do I know what I'm doing here (just guessing > :) > kde-multimedia, please help. > > > Subject: Re: Knotify and Network Audio System On Monday 28 October 2002 09:52, you wrote: Hi, > Oh no !!! > not this patch i try do it before ... > > it crash Sound preview and sound listen in Konqueror :(((( oh, thanks for telling this... > The only patch how work fine and don't crash anything is to ignore null in > knotify :( Ok, I reverted the patch in arts and removed the check for "null" in knotify, so everything should be fine now. I hope :) Cheers Carsten Pfeiffer |
(*** This bug was imported into bugs.kde.org ***) This is a multi-part message in MIME format. ------=_NextPart_000_0008_01C21D0B.0A266790 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Package: kdelibs Version: 3.0.1 We don't heard any notification sound if we use NAS (Network Audio System) = just the sound from playing mp3 or some file .... this is due to knotify in the function :=20 bool KNotify::notifyBySound( const QString &sound ); there's :=20 if (d->soundServer.audioDevice() =3D=3D "null") return false; this 2 lines must be deleted for the sound notification work on NAS (Networ= k Audio System). Good bye. See you Nicolas. ------=_NextPart_000_0008_01C21D0B.0A266790 Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML><HEAD> <META http-equiv=3DContent-Type content=3D"text/html; charset=3Diso-8859-1"> <META content=3D"MSHTML 6.00.2716.2200" name=3DGENERATOR> <STYLE></STYLE> </HEAD> <BODY bgColor=3D#ffffff> <DIV><FONT face=3DArial size=3D2>Package: kdelibs</FONT></DIV> <DIV><FONT face=3DArial size=3D2>Version: 3.0.1</FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2>We don't heard any notification sound if w= e use NAS=20 (Network Audio System) just the sound from playing mp3 or some file=20 ....</FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2>this is due to knotify</FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2>in the function : </FONT></DIV> <DIV><FONT face=3DArial size=3D2>bool KNotify::notifyBySound( const QString= =20 &sound );</FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2>there's : </FONT></DIV> <DIV><FONT face=3DArial size=3D2> = if=20 (d->soundServer.audioDevice() =3D=3D=20 "null")<BR> &nbs= p;=20 return false;<BR></FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2>this 2 lines must be deleted for the = sound=20 notification work on NAS (Network Audio System).</FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2>Good bye.</FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2>See you</FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV><FONT face=3DArial size=3D2>Nicolas.</FONT></DIV> <DIV><FONT face=3DArial size=3D2></FONT> </DIV> <DIV> </DIV></BODY></HTML> ------=_NextPart_000_0008_01C21D0B.0A266790--