Bug 437828

Summary:	Clicking on format control buttons in sticky notes removes focus from the text area
Product:	[Plasma] kdeplasma-addons	Reporter:	Kishore Gopalakrishnan <kishore96>
Component:	notes	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR	Keywords:	usability
Version:	5.21.90
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	https://invent.kde.org/plasma/kdeplasma-addons/commit/343967d79417392e397a0989ccc4d40ab5f9054d	Version Fixed In:	5.22.1

Description Kishore Gopalakrishnan 2021-05-29 14:17:19 UTC

SUMMARY
Sticky notes show a set of buttons at the bottom (bold, italic, etc.). If the cursor is initially in the Sticky Note's text area and we click on one of these buttons, focus is removed from the text area, such that if we continue typing, krunner is invoked instead.

STEPS TO REPRODUCE
1. Add a sticky note to your desktop
2. Place the focus in the note and type something
3. Now click the 'bold' button at the bottom of the note
4. Continue typing

OBSERVED RESULT
Krunner is invoked with the typed text in step 4.

EXPECTED RESULT
Typed text in step 4 should be entered in the Sticky Note, and not passed to krunner.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.21.90
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2021-06-08 20:54:59 UTC

Wow weird! I think I might know how to fix this, though.

Comment 2 Bug Janitor Service 2021-06-08 20:59:57 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/71

Comment 3 Nate Graham 2021-06-14 13:59:46 UTC

Git commit 5a78f3cd6b6332679a5f0d6bfbd7ca8f2faafa84 by Nate Graham.
Committed on 14/06/2021 at 13:59.
Pushed by ngraham into branch 'master'.

[applet/notes] Don't focus buttons on click

Otherwise the text field loses focus and typing causes KRunner to
intercept the keystrokes. Instead, only allow the buttons to gain focus
when manually focused using the tab key.
FIXED-IN: 5.22.1

M  +6    -0    applets/notes/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/5a78f3cd6b6332679a5f0d6bfbd7ca8f2faafa84

Comment 4 Nate Graham 2021-06-14 14:00:12 UTC

Git commit 343967d79417392e397a0989ccc4d40ab5f9054d by Nate Graham.
Committed on 14/06/2021 at 14:00.
Pushed by ngraham into branch 'Plasma/5.22'.

[applet/notes] Don't focus buttons on click

Otherwise the text field loses focus and typing causes KRunner to
intercept the keystrokes. Instead, only allow the buttons to gain focus
when manually focused using the tab key.
FIXED-IN: 5.22.1


(cherry picked from commit 5a78f3cd6b6332679a5f0d6bfbd7ca8f2faafa84)

M  +6    -0    applets/notes/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/343967d79417392e397a0989ccc4d40ab5f9054d