Bug 40456

Summary:	JavaScript causing Konqueror to "forget" back button location [PATCH]
Product:	[Applications] konqueror	Reporter:	Bernhard Rosenkraenzer <bero>
Component:	kjs	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hausmann, mattsheffield
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Other
Latest Commit:		Version Fixed In:

Description Bernhard Rosenkraenzer 2002-04-08 11:48:27 UTC

(*** This bug was imported into bugs.kde.org ***)

Package: KJS
Version: KDE_3_0_BRANCH as of 2002/04/04

Details at
http://www.mplug.org/archive/2002/konq_space_bug/

Comment 1 David Faure 2002-10-29 19:42:58 UTC

I see no %20 anywhere with Konqueror-3.1-rc1, so the parsing bug seems to be      
fixed.      
However in http://www.mplug.org/archive/2002/konq_space_bug/example.html, 
the link, which first goes to the test dir and then to the      
/this/url/does/not/matter URL, triggers a bug in konqueror's history code: if the test     
dir has been loaded previously (so it's in kio_http's cache), konqueror manages to     
load it during that short time, but saves a wrong history entry (with the title of     
contents of example.html).     
     
This patch fixes it. But we're so close to KDE-3.1, I don't feel like committing such     
a change at this point, at least without testing and review :}    
   
diff -u -p -r1.316 konq_view.cc   
--- konq_view.cc	2002/10/17 16:24:50	1.316   
+++ konq_view.cc	2002/10/29 18:06:30   
@@ -470,10 +470,8 @@ void KonqView::slotCompleted( bool hasPe   
    
   if ( ! m_bLockHistory )   
   {   
-      // Success... update location bar URL   
-      HistoryEntry * current = m_lstHistory.current();   
-      if ( current )   
-          current->locationBarURL = m_sLocationBarURL;   
+      // Success... update history entry, including location bar URL   
+      updateHistoryEntry(true);   
    
       if ( m_bAborted ) // remove the pending entry on error   
           KonqHistoryManager::kself()->removePending( url() );

Comment 2 David Faure 2002-10-29 19:47:42 UTC

*** Bug 40788 has been marked as a duplicate of this bug. ***

Comment 3 David Faure 2002-11-28 18:29:21 UTC

I did commit the patch before 3.1.