Bug 380778

Summary: FIXED IN SVN: Expand dialogs when showing code
Product: [Applications] rkward Reporter: RKWard Team <rkward-devel>
Component: generalAssignee: RKWard Team <rkward-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: All   
Latest Commit: Version Fixed In:

Description RKWard Team 2011-09-04 12:33:51 UTC 
-- Originally posted by (AT sourceforge.net): nalimilan --

-- This ticket was imported from http://sourceforge.net/p/rkward/bugs/97 on 2017-05-30 15:26:59 +0100 --
So, with recent versions dialogs are correclty sized by default, which is great. But if you click on the "Code" button, you still only see one line of the multi-line entry \(and that line is blank\). The dialog should really resize to something reasonable, I suggest the dialog expands to the bottom of the screen in all cases, since people clicking on "Code" probably want to read that code correctly \(even if it hides the main window\). Clicking on "Code" again should resize the window to the original size.

\(I think I read in planet.gnome.org recently that all common window managers force the window height to the screen size if you ask for something too big, so you probably can just request 1000px or so.\)-- Labels: user interface --
Comment 1 Thomas Friedrichsmeier 2011-09-14 06:26:07 UTC 
Hi\!

Actually, the dialog \_is\_ resized when clicking on the code button. And in fact, the amount by which it is resized \(i.e. the height of the code display\) can be configured at Settings-&gt;Configure RKWard-&gt;Plugins. However, in fact, the default value for that was set to an unreasonably small 40px. I have now adjusted that to 250px in the development version.

Using a fixed \(initial\) height of the code display may not be a terribly elegant solution. However, getting this right is not as easy as it may seem. Among other things:
\- The layout should be sane, whether or not the code display is shown initially \(a configurable option\).
\- Toggling the code display should work well, whether the dialog is placed near the top or the bottom of the screen.
\- When toggling, the layout of the upper portion of the dialog should not jump too much.
\- The dialog should react well to user resizing, whether or not the code display is shown.
\- Should work well on a large variety of screen resolutions.

Well, I don't claim the current solution is the best possible one, but a good deal of trial and error preceded it. Thus, to me, this is a mix of "fixed" \(default size setting\) and "won't fix". Of course, if you can provide a patch that "just works", I'll be more than happy to apply it \(main function to look at is RKStandardComponentGUI::toggleCode\(\)\).

Regards
Thomas
Comment 2 Thomas Friedrichsmeier 2011-09-14 06:26:07 UTC 
- **summary**: Expand dialogs when showing code --> FIXED IN SVN: Expand dialogs when showing code
- **status**: open --> open-fixed
Comment 3 RKWard Team 2011-09-14 07:46:29 UTC 
-- Originally posted by (AT sourceforge.net): nalimilan --
No problem, that's OK with me too.Thanks\!

I would say you don't need a setting to allow users to change this value, but that's probably a GNOMEr POV. ;-\)
Comment 4 Thomas Friedrichsmeier 2011-10-24 07:13:21 UTC 
- **status**: open-fixed --> closed-fixed