Bug 378561

Summary: Definitions of frames with colour and line are not stored for reports
Product: [Applications] KEXI Reporter: Albrecht Will <albrecht.will>
Component: Reports and PrintoutsAssignee: Adam Pigg <adam>
Status: CLOSED FIXED    
Severity: normal CC: adam, inksi, staniek
Priority: HI    
Version: 3.0.1   
Target Milestone: 3.0.2   
Platform: Arch Linux   
OS: Linux   
URL: https://phabricator.kde.org/D5391
Latest Commit: Version Fixed In: 3.0.2
Attachments: report without the choosen line-stile and colour
Sample db

Description Albrecht Will 2017-04-08 14:16:10 UTC
Created attachment 104923 [details]
report without the choosen line-stile and colour

In view-mode i choose for a text the line style und its colour. After storing, in view-mode its all lost. Opening the view, there is nothing changed.
Comment 1 Jarosław Staniek 2017-04-10 14:52:37 UTC
Confirmed, it worked in 2.x.
Comment 2 Jarosław Staniek 2017-04-10 14:55:54 UTC
Line style is not loaded but it is saved. Also Line weight accepts floating point numbers but only loads integers.
Comment 3 Jarosław Staniek 2017-04-10 15:08:46 UTC
Regarding "Also Line weight accepts floating point numbers but only loads integers" In Kexi 3 we started support weights such as 2.5. They should be preserved. Kexi 2 will still support integer values only.

Related bug in Kexi 3 that adds to this issue: Changing properties of Field element does not set report as "modified" so the Save button stays disables. User is able close the design without saving changes. Other types of elements such as Label don't have this issue.
Comment 4 Jarosław Staniek 2017-04-10 15:59:56 UTC
Created attachment 104950 [details]
Sample db
Comment 5 Adam Pigg 2017-04-10 21:25:56 UTC
I wasnt able to re-produce the problem of fields not setting the 'save' button status.  worked fine for the properties i changed.

https://phabricator.kde.org/D5391

The original code incorrectly stored the penstyle as a pen.  it seems this was added in kreport3 becuase qt5 removed storing a penstlye in a qvariant.  recommended options are to cast to an int, as here, or declare a metatype. https://forum.qt.io/topic/23038/solved-qt5-and-qvariant/2
Comment 6 Jarosław Staniek 2017-04-10 22:53:34 UTC
> I wasnt able to re-produce the problem of fields not setting the 'save' button status.  worked fine for the properties i changed.

I would look at this separately, thanks.