Summary: | patch review shouldn't add files it opens to the recent files menu | ||
---|---|---|---|
Product: | [Developer tools] kdevplatform | Reporter: | RJVB <rjvbertin> |
Component: | patchreview | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | david.nolden.kde, simonandric5 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | All | ||
URL: | https://git.reviewboard.kde.org/r/129231/ | ||
Latest Commit: | http://commits.kde.org/kdevplatform/3c559df38551ba0a0654e944ea2b68dd4b85a15d | Version Fixed In: | 5.1.0 |
Attachments: | patch review temporary patchfiles in the recent files menu |
Description
RJVB
2016-10-19 10:09:16 UTC
Created attachment 101650 [details]
patch review temporary patchfiles in the recent files menu
The large number of changed files that overwrote my recent files menu contents hid another thing that I think is a real and recent regression: the presence of the patch files themselves in the recent files menu.
Git commit 3c559df38551ba0a0654e944ea2b68dd4b85a15d by René J.V. Bertin. Committed on 21/10/2016 at 14:51. Pushed by rjvbb into branch 'master'. add an IDocumentController::DocumentActivation flag to control adding documents to the "Files/Open Recent" menu and use it in the patchreview plugin to prevent pollution of said menu. DocumentController::activateDocument() no longer adds the target document to the Open Recent menu; use DocumentController::openDocument() for that. Additionally, the patch review plugin now handles the hardwired maximum number of files to open (15) correctly, instead of opening no files when that maximum is exceeded. REVIEW: 129231 M +2 -1 interfaces/idocumentcontroller.h M +21 -19 plugins/patchreview/patchreview.cpp M +7 -2 plugins/patchreview/patchreviewtoolview.cpp M +2 -2 shell/documentcontroller.cpp M +2 -0 shell/documentcontroller.h http://commits.kde.org/kdevplatform/3c559df38551ba0a0654e944ea2b68dd4b85a15d |