Bug 363082

Summary: Brokerage account isn't s selectable during import of investment statement
Product: [Applications] kmymoney Reporter: NSLW <lukasz.wojnilowicz>
Component: importerAssignee: KMyMoney Devel Mailing List <kmymoney-devel>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: git (master)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/kmymoney/b1c0ef8a2553ab44938829dc0870ea6796e27c8f Version Fixed In: 5.0
Attachments: New way of selecting brokerage account

Description NSLW 2016-05-14 19:35:09 UTC 
It's not a bug, it's proposal of improvement. If during import of CSV investment statement, brokerage account isn't automatically detected user has to type it in manually. User can make a typo and if he doesn't have brokerage account yet, he has no possibility to create it at site.

Reproducible: Always

Steps to Reproduce:
1. File->Import->CSV... 
2. choose Investing, 
3. proceed with importing till question about brokerage account

Actual Results:  
KMM asks user about brokerage account through simple input window.

Expected Results:  
KMM should ask user about brokerage like in case of investment account i.e. through account selector because ui is more consistent with it and account selector is comfortable to handle.
Comment 1 NSLW 2016-05-14 19:36:08 UTC 
Created attachment 98976 [details]
New way of selecting brokerage account
Comment 2 NSLW 2016-06-24 18:45:36 UTC 
Git commit daffd1caf5c52656b1fbc520a497cad5dc8a6501 by Łukasz Wojniłowicz.
Committed on 24/06/2016 at 18:43.
Pushed by wojnilowicz into branch 'master'.

Get rid of inputParameter for brokerage account

Functionality of inputParameter is replaced with KAccountSelectDlg.
REVIEW: 128101

M  +0    -10   kmymoney/plugins/csvimport/investprocessing.cpp
M  +0    -9    kmymoney/plugins/csvimport/redefinedlg.cpp

http://commits.kde.org/kmymoney/daffd1caf5c52656b1fbc520a497cad5dc8a6501
Comment 3 NSLW 2016-06-24 18:56:33 UTC 
Git commit b1c0ef8a2553ab44938829dc0870ea6796e27c8f by Łukasz Wojniłowicz.
Committed on 24/06/2016 at 18:45.
Pushed by wojnilowicz into branch 'master'.

Use KAccountSelectDlg to select brokerage account

If there is no "Account (Brokerage)" user should be asked to select
brokerage account.
REVIEW: 127920

M  +14   -0    kmymoney/converter/mymoneystatementreader.cpp
M  +8    -0    kmymoney/converter/mymoneystatementreader.h

http://commits.kde.org/kmymoney/b1c0ef8a2553ab44938829dc0870ea6796e27c8f