Summary: | Notification Settings wrong default display for notifications and notifaction position. | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Artur O. <commander.alchemy> |
Component: | Notifications | Assignee: | Martin Klapetek <mklapetek> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | auxsvr, bjorn.bidar, db0451, herzenschein, kde, kde, kde, kdelibs-bugs, olaf.the.lost.viking, plasma-bugs, raghu, rdieter |
Priority: | NOR | ||
Version: | 5.5.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
picture of notification settings and display settings.
picture of notification when default position is used. picture of notification when topright position is used. picture of notification when middletop position is used. picture of notification when middlebottom position is used. Debug patch |
Description
Artur O.
2015-12-10 11:46:02 UTC
Created attachment 95968 [details]
picture of notification settings and display settings.
This shows the Notification Settings having the portrait monitor (0x0) as template for settings instead of my primary monitor.
Created attachment 95969 [details]
picture of notification when default position is used.
Um about the position of the notification and relative to mouse. It now seems that it's random. Sometimes it fires up on left sometimes on middle no matter where the mouse is!
Created attachment 95970 [details]
picture of notification when topright position is used.
Correct position of what I want but seems wrong that it shows portrait monitor when its my primary landscape.
Created attachment 95971 [details]
picture of notification when middletop position is used.
Created attachment 95972 [details]
picture of notification when middlebottom position is used.
Git commit 5d56df0d53851a8cd61344d356bcb552220dd3ed by Martin Klapetek. Committed on 10/12/2015 at 21:29. Pushed by mklapetek into branch 'Plasma/5.5'. [notifications] Fix default notification position setting It can happen that the onAppletLocationChanged() slot gets called before init(), making init() reset the calculated position from the slot. M +5 -2 applets/notifications/lib/notificationsapplet.cpp http://commits.kde.org/plasma-workspace/5d56df0d53851a8cd61344d356bcb552220dd3ed Is this patch inclued in 5.5? Cause the notification is still on the wrong screen. (In reply to Thaodan from comment #7) > Is this patch inclued in 5.5? Cause the notification is still on the wrong > screen. This happend after 5.5 release so don't think so. Would it be possible to backport the patch to 5.5? It is backported to the 5.5 branch, it is not in 5.5.0 it will be in 5.5.1 Created attachment 96065 [details]
Debug patch
Is anyone with any multi-screen setup able to test simple patches?
I'm just interested in some debug output of how the notifications
applet chooses the screen it puts the notifications on. So if you can
apply patches, please try this attached one, apply to plasma-workspace,
rebuild (just applets/notifications is enough), install over the system
one, run "kquitapp5 plasmashell" and then just "plasmashell" from
Konsole and post the output starting with "-->" these.
Also please state what's your multiscreen setup.
possibly related to wider scale mis-selection of screen as documented in https://bugs.kde.org/show_bug.cgi?id=346181 I might be able to test your patch within the next couple of days once the rest of my newly migrated Debian testing installation is stable (relatively speaking). Perhaps, although the notifications applet has in addition its own code to select the screen where to put the popups. What it does is that it takes the screen information from Plasma, looks for a system screen that matches the one received from Plasma and then it intersects that screen with your "work area", that is the screen available space without panels. But this is good for a single setup only, because as soon as you add a screen that has a different resolution, the work area will be the "bounding box", ie. the outer rectangle containing all of your screens, so the screen with the smaller resolution will have an empty space appended at its bottom part. This becomes rather bad with setups like Artur's (if you look at his screenshots), because with the screen being in vertical mode, there's a lots of empty spaced attached to the other screens. So ideally I'd like to switch away from work area altogether, but it's hard to do so because I have just a single (laptop) screen, so I need someone to test patches. (In reply to Martin Klapetek from comment #13) > Perhaps, although the notifications applet has in addition its > own code to select the screen where to put the popups. > > What it does is that it takes the screen information from Plasma, > looks for a system screen that matches the one received from > Plasma and then it intersects that screen with your "work area", > that is the screen available space without panels. > > But this is good for a single setup only, because as soon as you > add a screen that has a different resolution, the work area will > be the "bounding box", ie. the outer rectangle containing all > of your screens, so the screen with the smaller resolution will > have an empty space appended at its bottom part. > > This becomes rather bad with setups like Artur's (if you look at > his screenshots), because with the screen being in vertical mode, > there's a lots of empty spaced attached to the other screens. So > ideally I'd like to switch away from work area altogether, but it's > hard to do so because I have just a single (laptop) screen, so I need > someone to test patches. Tried to find a git package in aur but for some reason plasma-desktop-git does not contain the notification applet. However the 5.5.1 just went live on arch. Atm default position seems to be a bit random. Mostly it displays on the bottom lower right corner of the working display (middle/primary). Spamming notify send it sometimes just shows up on my left monitor in the middle. After updating to 5.5.1, the notifications appear mostly on the lower left and occasionally on the right corner of a single-monitor desktop. Before the update, I had no such problem. > for some reason plasma-desktop-git does not contain the notification applet
It's part of plasma-workspace.
---
@auxsvr - what if you force the position to bottom-right in the applet settings?
I'll review the code once again for possible mistakes.
(In reply to Martin Klapetek from comment #16) > > for some reason plasma-desktop-git does not contain the notification applet > > It's part of plasma-workspace. Um for some reason the arch pkg is named plasma-desktop but it's plasma-workspace. https://aur.archlinux.org/packages/plasma-desktop-git/ @Martin Klapetek : I am seeing this on Fedora 23 , fully updated (although without this update which is still in testing : https://bodhi.fedoraproject.org/updates/FEDORA-2015-f0aa62dc50 ). I can easily reproduce it by calling "notify-send test" from the command line - the popup appears on the left, not the right. What if you force the position to bottom-right in the applet settings? I can't see any settings for location. Popups are not movable to a location as far as I can see. And notify-send does not provide anything for that. Right-click the applet in your panel -> Notifications settings... -> Use custom position for the notifications popups. *Interesting* - never knew that was there ;-) Ok I am at home not at work so this is testing in a single laptop configuration. Previously the popups would appear on the left hand side of the laptop screen rather than right. Custom selecting the right hand side does indeed make them appear in the correct place. Bizarrely deselecting custom location - they still now appear on the right hand side. For me setting the custom location in notification solves thew problem and this setting now persists after reboot unlike earlier. I am on arch and can say this now works as intended (In reply to Raghavendra kamath from comment #23) > For me setting the custom location in notification solves thew problem and > this setting now persists after reboot unlike earlier. I am on arch and can > say this now works as intended This bug report is about the default position not custom position. I still have the problem with the incorrect placement of the notifications even after forcing them to display on the lower right corner of the desktop (by the way, I had already done this before and refreshed the setting). Most notifications now appear on the right, but the ones from the nm plasmoid mostly appear on the left. I'm refactoring the whole positioning thing, stay tuned. Hi, Will that also cover these problems with various panel popups appearing on the wrong screen (in a random location) or not at all? https://bugs.kde.org/show_bug.cgi?id=346181 Thanks! No, that's a whole different thing. Btw. I could still really really use the output from the patch in comment #11. Patch up at https://git.reviewboard.kde.org/r/126408/ if anybody wants to give it a try. That would help a lot if someone else could test it. (In reply to Martin Klapetek from comment #29) > Patch up at https://git.reviewboard.kde.org/r/126408/ if anybody > wants to give it a try. That would help a lot if someone else could > test it. I tried your patch on workspace-git. Default position now seems to be top-right of where the notification widget is located (primary desktop for me, middle). Spammed also the notifications with a simple for loop and notify send and they seem stable. Downgraded back to 1.5.1 and did the same, had to redo "unchecked custom position" that for some reason was checked, but doing the for loop the notifications came at different positions and even size. Summa summarum: I think the patch works (fixes default to top-right, and stable notifications) at least for me and my "odd" setup. Thanks for your work Martin, and happy holidays! For anyone else wanting to try this patch and is running arch, try this pkgbuild https://gist.github.com/CommanderAlchemy/69eb96b5624a889bdea0 (drop in replacement for current plasma-workspace). *** Bug 356977 has been marked as a duplicate of this bug. *** Git commit 0c6b354b7e22297544f1d37608d6fdcd777c4d52 by Martin Klapetek. Committed on 05/01/2016 at 04:52. Pushed by mklapetek into branch 'Plasma/5.5'. [notifications] Refactor the screen handling code This patch does this: * moves the screen handling code from the import into the applet baseclass, which can access the containment available screen rect and watch for screen changes * fixes the applet config dialog's custom screen position setting which has a bug of always being enabled * consolidates duplicated code in the helper import into functions * ensures that popups have correct positions when on screen that does not start with y=0 (and x=0 in some cases too) REVIEW: 126408 Related: bug 353966 M +1 -0 applets/notifications/lib/CMakeLists.txt M +69 -25 applets/notifications/lib/notificationsapplet.cpp M +15 -2 applets/notifications/lib/notificationsapplet.h M +7 -1 applets/notifications/package/contents/ui/Notifications.qml M +1 -1 applets/notifications/package/contents/ui/configNotifications.qml M +2 -3 applets/notifications/plugin/CMakeLists.txt M +57 -55 applets/notifications/plugin/notificationshelper.cpp M +4 -2 applets/notifications/plugin/notificationshelper.h http://commits.kde.org/plasma-workspace/0c6b354b7e22297544f1d37608d6fdcd777c4d52 I'm guessing the commit did not autoclose this bug report? I'm setting this as RESOLVED/FIXED if it's alright, given there was no answer after the patch and that (AFAIK) there were major changes to the notifications in recent years. If this is still reproducible, please file a new bug report. |