Summary: | Notifications cover panel if secondary display is taller than main | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | William Termini <kdebugs> |
Component: | Notifications | Assignee: | Martin Klapetek <mklapetek> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, kdebugs, plasma-bugs |
Priority: | NOR | ||
Version: | 5.5.1 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
URL: | http://imgur.com/a/xvcX7 | ||
Latest Commit: | Version Fixed In: |
Description
William Termini
2015-10-16 15:48:50 UTC
Thanks for the report. Which Qt version are you using please? Qt Version 5.5.0 (In reply to William Termini from comment #2) > Qt Version 5.5.0 Ok, are you able to test patches? It's a simple patch for the notifications applet which would help tremendously. (In reply to Martin Klapetek from comment #4) > Ok, are you able to test patches? It's a simple patch for the > notifications applet which would help tremendously. I have never tested a patch before but I am sure I could figure it out if you point me in the right direction. Git commit 0c6b354b7e22297544f1d37608d6fdcd777c4d52 by Martin Klapetek. Committed on 05/01/2016 at 04:52. Pushed by mklapetek into branch 'Plasma/5.5'. [notifications] Refactor the screen handling code This patch does this: * moves the screen handling code from the import into the applet baseclass, which can access the containment available screen rect and watch for screen changes * fixes the applet config dialog's custom screen position setting which has a bug of always being enabled * consolidates duplicated code in the helper import into functions * ensures that popups have correct positions when on screen that does not start with y=0 (and x=0 in some cases too) REVIEW: 126408 Related: bug 356461 M +1 -0 applets/notifications/lib/CMakeLists.txt M +69 -25 applets/notifications/lib/notificationsapplet.cpp M +15 -2 applets/notifications/lib/notificationsapplet.h M +7 -1 applets/notifications/package/contents/ui/Notifications.qml M +1 -1 applets/notifications/package/contents/ui/configNotifications.qml M +2 -3 applets/notifications/plugin/CMakeLists.txt M +57 -55 applets/notifications/plugin/notificationshelper.cpp M +4 -2 applets/notifications/plugin/notificationshelper.h http://commits.kde.org/plasma-workspace/0c6b354b7e22297544f1d37608d6fdcd777c4d52 Thank you for your work, I can confirm my notifications are appearing properly now. |