| Summary: | Allow changing angle unit with right click on status bar | ||
|---|---|---|---|
| Product: | [Applications] marble | Reporter: | Dennis Nienhüser <nienhueser> |
| Component: | general | Assignee: | marble-bugs |
| Status: | RESOLVED FIXED | ||
| Severity: | task | CC: | stanciumarius94 |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Added a menu that allows to change the angle unit from the status bar. | ||
|
Description
Dennis Nienhüser
2015-02-19 20:45:11 UTC
Created attachment 91217 [details]
Added a menu that allows to change the angle unit from the status bar.
Thanks for the patch! The code looks fine. Just some nitpicking mostly wrt code style: - change m_DMSDegreeAction to m_dmsDegreeAction etc (first letter after m_ should be lowercase) - Menu entries should have title capitalization, so "&Change angle unit" becomes "&Change Angle Unit". I'd prefer the wording "&Angle Display Unit" here (i.e. not active). See https://techbase.kde.org/Projects/Usability/HIG/Capitalization - the doxygen comment for statusBarChangesAngleUnit is at the wrong place, possibly you moved the method around without moving its comment I didn't try the code yet, but from reading over it I'd say there is a bug when clicking on "show tile zoom level": it will change the angle unit also. It would be great if you could post subsequent patches to http://git.reviewboard.kde.org against the marble repository, putting the marble group as reviewers and the id of this bug (344364) as the bug number. Reviewboard generates nice colored diffs and allows commenting on lines, making it much easier to discuss code changes and track them. Alright, thanks for the quick feedback, my first patch yet so it's really usefull. I'll post it there as soon as i'm done with it then! There's a new patch at https://git.reviewboard.kde.org/r/124287 Hope you don't mind if I go for that one now. Git commit 7f63f9c9c8e1987d581015a222e192cd832c607e by Dennis Nienhüser, on behalf of Alexey Bugrov. Committed on 25/07/2015 at 05:42. Pushed by nienhueser into branch 'master'. Allow changing angle unit with right click on status bar (Qt Marble) REVIEW: 124287 M +48 -0 src/apps/marble-qt/QtMainWindow.cpp M +5 -0 src/apps/marble-qt/QtMainWindow.h M +7 -0 src/lib/marble/QtMarbleConfigDialog.cpp M +1 -0 src/lib/marble/QtMarbleConfigDialog.h http://commits.kde.org/marble/7f63f9c9c8e1987d581015a222e192cd832c607e Now it'd be awesome if we had the same functionality in KDE Marble (which shows a slightly different context menu in the status bar currently and has a different way of saving settings, but is quite similar otherwise). Any volunteer? |