Bug 34302

Summary: buttons/pictures missing at http://bscw.gmd.de
Product: [Applications] konqueror Reporter: hoea
Component: khtmlAssignee: Konqueror Developers <konq-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 2.2.1   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In:

Description hoea 2001-10-30 22:20:53 UTC 
(*** This bug was imported into bugs.kde.org ***)

Package:           khtml
Version:           2.2.1 (using KDE 2.2.1 )
Severity:          normal
Installed from:    SuSE RPMs
Compiler:          Not Specified
OS:                Linux
OS/Compiler notes: suse 7.3

load http://bscw.gmd.de
below the banner there should be 5 buttons/pictures - konqueror shows just 3 of them

(Submitted via bugs.kde.org)
Comment 1 Daniel Naber 2001-11-27 18:11:53 UTC 
Sorry but that page is broken so badly - it's not a khtml bug but a bug in the page.
Comment 2 Dirk Mueller 2003-01-08 04:17:21 UTC 
not a bug in the page, but in khtml
Comment 3 Dirk Mueller 2003-01-08 11:35:01 UTC 
Subject: kdelibs/khtml/html

CVS commit by mueller: 

handle <!--> and <!--->
CCMAIL:34302-done@bugs.kde.org


  M +9 -4      htmltokenizer.cpp   1.252


--- kdelibs/khtml/html/htmltokenizer.cpp  #1.251:1.252
@@ -7,5 +7,6 @@
               (C) 1999 Lars Knoll (knoll@kde.org)
               (C) 1999 Antti Koivisto (koivisto@kde.org)
-              (C) 2001 Dirk Mueller (mueller@kde.org)
+              (C) 2001-2003 Dirk Mueller (mueller@kde.org)
+              (C) 2002 Apple Computer, Inc.
 
     This library is free software; you can redistribute it and/or
@@ -750,8 +751,12 @@ void HTMLTokenizer::parseTag(DOMStringIt
                         ++src;
                         dest = buffer; // ignore the previous part of this tag
-                        comment = true;
                         tag = NoTag;
-                        parseComment(src);
 
+                        comment = true;
+                        // push what we parsed so far upon the stack. helps for <!-->
+                        checkScriptBuffer();
+                        scriptCode[0] = scriptCode[1] = '-';
+                        scriptCodeSize = 2;
+                        parseComment(src);
                         return; // Finished parsing tag!
                     }