Bug 34068

Summary:	WIsh: Don't disable RMB for tool bars in fullscreen mode
Product:	[Applications] konqueror	Reporter:	kde
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	maksim
Priority:	NOR
Version:	2.2.1
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:

Description kde 2001-10-24 11:11:52 UTC

(*** This bug was imported into bugs.kde.org ***)

Package:           konqueror
Version:           2.2.1 (using KDE 2.2.1 )
Severity:          normal
Installed from:    Debian Package 4:2.2.1-5 (testing/unstable)
Compiler:          gcc version 2.95.4 20010902 (Debian prerelease)
OS:                Linux (i686) release 2.4.12-jb-w4l
OS/Compiler notes: 

Subject says it all. Take Konqueror in full-screen mode and then try changing the toolbar icon size (or text display options) via RMB. Doesn't work. Works when you leave fullscreen mode.

Shouldn't be too hard to fix (I suppose). Thanks a lot ;)



(Submitted via bugs.kde.org)
(Called from KBugReport dialog)

Comment 1 Jens 2002-11-22 20:10:41 UTC

This is still the case in 3.0.4.

Comment 2 Maksim Orlovich 2002-12-09 03:51:56 UTC

Hmm, the code actually disables the menu explictily, but only as a workaround to disable 
flattening -- except that with Qt 3.0.x (and probably others) one could flatten by clikcing on the 
handle anyway...

Comment 3 Maksim Orlovich 2002-12-27 18:07:41 UTC

Subject: kdebase/konqueror

CVS commit by orlovich: 


Ask discussed with DFaure: remove disabling of context menus for toolbars when in fullscreen mode; 
it was put in in KDE-1.92 or so era to workaround some bug involving floating toolbars; since one can easily
float toolbar w/o the context menu anyway, and since it works just fine with the toolbars floating nowadays,
bring the menu back.

Fixes #34068

CCMAIL:34068-done@bugs.kde.org


  M +0 -8      konq_mainwindow.cc   1.1100


--- kdebase/konqueror/konq_mainwindow.cc  #1.1099:1.1100
@@ -2800,8 +2800,4 @@ void KonqMainWindow::slotToggleFullScree
     plugActionList( "fullscreen", lst );
 
-    QPtrListIterator<KToolBar> barIt = toolBarIterator();
-    for (; barIt.current(); ++barIt )
-        barIt.current()->setEnableContextMenu( false );
-
     menuBar()->hide();
     m_paShowMenuBar->setChecked( false );
@@ -2822,8 +2818,4 @@ void KonqMainWindow::slotToggleFullScree
   {
     unplugActionList( "fullscreen" );
-
-    QPtrListIterator<KToolBar> barIt = toolBarIterator();
-    for (; barIt.current(); ++barIt )
-        barIt.current()->setEnableContextMenu( true );
 
     menuBar()->show(); // maybe we should store this setting instead of forcing it