Bug 337389

Summary: The visibility of the "Places selector" in the location bar is often wrong (recent regression)
Product: [Applications] dolphin Reporter: Frank Reininghaus <frank78ac>
Component: bars: locationAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 16.12.2   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/kde-baseapps/15e68c7a02bee0c2c7ee36228ab5043544e0f428 Version Fixed In: 4.14.0

Description Frank Reininghaus 2014-07-12 08:22:56 UTC 
The "Places Selector" at the front of the location bar should be shown if and only if the Places Panel is hidden.

Since https://git.reviewboard.kde.org/r/118964/, there are two problems with this functionality:

1. In new tabs, the expected visibility of the selector is reversed.

2. When splitting the view, the selector is always shown in the new view.


Reproducible: Always

Steps to Reproduce:
1. Open Dolphin
2. Press F9 repeatedly to show/hide the Places Panel

alternatively:

1. Open Dolphin
2. Split the view.
Actual Results:  
The Places selector is always shown if the Places Panel is shown.

When splitting the view, the new view always has a Places selector.

Expected Results:  
The Places selector should be shown if and only if the Places Panel is hidden.
Comment 1 Frank Reininghaus 2014-07-16 07:15:37 UTC 
Git commit 15e68c7a02bee0c2c7ee36228ab5043544e0f428 by Frank Reininghaus.
Committed on 16/07/2014 at 07:12.
Pushed by freininghaus into branch 'KDE/4.14'.

Fix regression concerning the "Places" selector in the location bar

This commit ensures that the selector is visible in all location bars
if and only if the Places Panel is hidden. It fixes a regression caused
by commit 6a98d83312ff2b14ab878e1427bbace3b683eacc.
FIXED-IN: 4.14.0
REVIEW: 119238

M  +2    -1    dolphin/src/dolphinmainwindow.cpp
M  +4    -0    dolphin/src/dolphintabpage.cpp

http://commits.kde.org/kde-baseapps/15e68c7a02bee0c2c7ee36228ab5043544e0f428