Bug 333247

Summary:	Equality operators for Schema and SimpleField
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	Sanjiban Bairagya <sanjiban22393>
Status:	RESOLVED FIXED
Severity:	task	Keywords:	junior-jobs
Priority:	NOR
Version:	1.7 (KDE 4.12)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/2337dc2816111884823c4c920c482cb0e56df2c7	Version Fixed In:

Description Dennis Nienhüser 2014-04-09 21:03:55 UTC

Add operator== and operator!= to the classes GeoDataSimpleField and GeoDataSchema. Make sure to also call the equals() method of GeoDataObject in GeoDataSchema. Extend TestEquality by a new unit test method for each class which verifies the implementation for several instances of each class.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and run the test case from the build folder (run tests/TestEquality). Note that operator!= should call operator==, see GeoDataAccuracy for an example. Submit a review request at https://git.reviewboard.kde.org.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.

Comment 1 Dennis Nienhüser 2014-04-10 14:58:06 UTC

Git commit 2337dc2816111884823c4c920c482cb0e56df2c7 by Dennis Nienhüser, on behalf of Sanjiban Bairagya.
Committed on 10/04/2014 at 14:57.
Pushed by nienhueser into branch 'master'.

Equality operators for Schema and SimpleField
REVIEW: 117483

M  +13   -0    src/lib/marble/geodata/data/GeoDataSchema.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataSchema.h
M  +12   -0    src/lib/marble/geodata/data/GeoDataSimpleField.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataSimpleField.h
M  +63   -0    tests/TestEquality.cpp

http://commits.kde.org/marble/2337dc2816111884823c4c920c482cb0e56df2c7