Bug 333119

Summary:	Equality operators for track related classes
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	marble-bugs
Status:	RESOLVED FIXED
Severity:	task	CC:	crucerucalincristian, sanjiban22393
Priority:	NOR	Keywords:	junior-jobs
Version:	1.8 (KDE 4.13)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/83994bee3880f590d6dcdfd413fabe8bf7eb47e9	Version Fixed In:

Description Dennis Nienhüser 2014-04-06 08:56:01 UTC

Add operator== and operator!= to the classes GeoDataTrack and GeoDataMultiTrack. Make sure to also call the equals() method of GeoDataGeometry in each operator== implementation.
Extend TestEquality by a new unit test method for each class which verifies the implementation for several instances of each class.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and run the test case from the build folder (run tests/TestEquality). Note that operator!= should call operator==, see GeoDataAccuracy for an example. Submit a review request at https://git.reviewboard.kde.org.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.

Comment 1 Sanjiban Bairagya 2014-04-06 11:45:45 UTC

I want to work on this task

Comment 2 Cruceru Calin-Cristian 2014-04-07 08:48:32 UTC

Omg, I'm sorry Sanjiban Bairagya, I didn't see you commented on this :(. I saw that it is unconfirmed and started working on it and now, when I finished, I saw that you wanted to work on this. 
I promise I will leave to you a task in the future. 
Again, sorry.

Here is the bug review: https://git.reviewboard.kde.org/r/117416/ .

Comment 3 Cruceru Calin-Cristian 2014-05-03 13:09:19 UTC

Git commit 83994bee3880f590d6dcdfd413fabe8bf7eb47e9 by Cruceru Calin-Cristian.
Committed on 03/05/2014 at 13:07.
Pushed by crucerucalincristian into branch 'master'.

Equality operators for track related classes
REVIEW: 117416

M  +22   -0    src/lib/marble/geodata/data/GeoDataMultiTrack.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataMultiTrack.h
M  +15   -0    src/lib/marble/geodata/data/GeoDataTrack.cpp
M  +6    -0    src/lib/marble/geodata/data/GeoDataTrack.h
M  +104  -0    tests/TestEquality.cpp

http://commits.kde.org/marble/83994bee3880f590d6dcdfd413fabe8bf7eb47e9