Bug 331673

Summary:	Equality operators for GeoDataLatLonQuad, GeoDataLatLonBox, GeoDataLatLonAltBox, GeoDataLod and GeoDataRegion
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	Sanjiban Bairagya <sanjiban22393>
Status:	RESOLVED FIXED
Severity:	task	CC:	sanjiban22393
Priority:	NOR	Keywords:	junior-jobs
Version:	1.7 (KDE 4.12)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/f4a507ec9fe255e113302351538f9487207a9776	Version Fixed In:

Description Dennis Nienhüser 2014-03-02 08:01:06 UTC

Make it possible to check for equality using operator== in the following classes:
- GeoDataLatLonQuad (check the coordinates of the four corners)
- GeoDataLatLonBox (check corners and rotation)
- GeoDataLatLonAltBox (like GeoDataLatLonBox, but check minAltitude, maxAltitude and altitudeMode as well)
- GeoDataLod (check min and max lodPixels and fadeExtent)
- GeoDataRegion (check latLonAltBox and lod)

If bug 331666 is done by the time you work on this, integrate the equals() method of GeoDataObject into the operator== implementations.

Add unit test methods for each of the classes to tests/TestEquality.cpp. Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestEquality and make sure no errors come up. Use tools/kml2kml to analyze errors and fix the tag writers, if needed. Submit a review request at https://git.reviewboard.kde.org with the marble group as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.

Comment 1 Sanjiban Bairagya 2014-03-02 11:32:56 UTC

I want to work on this task

Comment 2 Dennis Nienhüser 2014-03-05 20:57:27 UTC

Git commit f4a507ec9fe255e113302351538f9487207a9776 by Dennis Nienhüser, on behalf of Sanjiban Bairagya.
Committed on 05/03/2014 at 20:50.
Pushed by nienhueser into branch 'master'.

Equality operators for GeoDataLatLonQuad, GeoDataLod and GeoDataRegion

REVIEW: 116572

M  +0    -1    src/lib/marble/geodata/data/GeoDataLatLonAltBox.cpp
M  +2    -2    src/lib/marble/geodata/data/GeoDataLatLonBox.h
M  +14   -0    src/lib/marble/geodata/data/GeoDataLatLonQuad.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataLatLonQuad.h
M  +13   -0    src/lib/marble/geodata/data/GeoDataLod.cpp
M  +4    -0    src/lib/marble/geodata/data/GeoDataLod.h
M  +11   -0    src/lib/marble/geodata/data/GeoDataRegion.cpp
M  +2    -1    src/lib/marble/geodata/data/GeoDataRegion.h
M  +199  -0    tests/TestEquality.cpp

http://commits.kde.org/marble/f4a507ec9fe255e113302351538f9487207a9776