Bug 331585

Summary:	Change GeoDataObject id and targetId from int to QString
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	Sanjiban Bairagya <sanjiban22393>
Status:	RESOLVED FIXED
Severity:	task	CC:	sanjiban22393
Priority:	NOR	Keywords:	junior-jobs
Version:	1.7 (KDE 4.12)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/5f4e803e6ac9fefd5a45ad93954264b9e6cceba9	Version Fixed In:

Description Dennis Nienhüser 2014-02-27 21:25:12 UTC

Currently the GeoDataObject class has an id and a targetId members, both int. They need to be QStrings though. Change them and the corresponding getters/setters.

Adjust PopupLayer.cpp and change
QString::number(placemark->id())
to a simple
placemark->id()
afterwards.

Remove the id member from the following classes: GeoDataTourControl, GeoDataTour, GeoDataWait, GeoDataSoundCue. Verify that the code still compiles (the classes will inherit id() from GeoDataObject now) and all unit tests pass.

Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Submit a review request at https://git.reviewboard.kde.org with the marble groups as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.

Comment 1 Sanjiban Bairagya 2014-02-27 21:26:39 UTC

I want to work on this task

Comment 2 Dennis Nienhüser 2014-02-28 08:26:48 UTC

Git commit 5f4e803e6ac9fefd5a45ad93954264b9e6cceba9 by Dennis Nienhüser, on behalf of Sanjiban Bairagya.
Committed on 28/02/2014 at 08:14.
Pushed by nienhueser into branch 'master'.

Change GeoDataObject id and targetId from int to QString

A string id is what the KML spec wants.

REVIEW: 116463

M  +8    -8    src/lib/marble/geodata/data/GeoDataObject.cpp
M  +4    -4    src/lib/marble/geodata/data/GeoDataObject.h
M  +0    -10   src/lib/marble/geodata/data/GeoDataSoundCue.cpp
M  +0    -4    src/lib/marble/geodata/data/GeoDataSoundCue.h
M  +0    -12   src/lib/marble/geodata/data/GeoDataTour.cpp
M  +0    -3    src/lib/marble/geodata/data/GeoDataTour.h
M  +0    -11   src/lib/marble/geodata/data/GeoDataTourControl.cpp
M  +0    -4    src/lib/marble/geodata/data/GeoDataTourControl.h
M  +0    -11   src/lib/marble/geodata/data/GeoDataWait.cpp
M  +0    -4    src/lib/marble/geodata/data/GeoDataWait.h
M  +1    -1    src/lib/marble/layers/PopupLayer.cpp
M  +3    -3    tests/TestGeoDataCopy.cpp

http://commits.kde.org/marble/5f4e803e6ac9fefd5a45ad93954264b9e6cceba9