Bug 331526

Summary:	Implement equality operators for GeoDataSimpleArrayData, GeoDataData and GeoDataExtendedData
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	Sanjiban Bairagya <sanjiban22393>
Status:	RESOLVED FIXED
Severity:	task	CC:	crucerucalincristian, sanjiban22393
Priority:	NOR	Keywords:	junior-jobs
Version:	1.8 (KDE 4.13)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/d7899fef51a81b98d8284c99783a2e5e552eb8b9	Version Fixed In:

Description Dennis Nienhüser 2014-02-26 09:29:08 UTC

Add operator== and operator!= to each of the classes GeoDataSimpleArrayData, GeoDataData and GeoDataExtendedData. Extend tests/TestEquality by a new unit test method for each of the classes which verifies the implementation for several instances of each class.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and run the test case from the build folder (run tests/TestEquality). Note that operator!= should call operator==, see GeoDataAccuracy for an example.

Submit a review request at https://git.reviewboard.kde.org

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.

Comment 1 Cruceru Calin-Cristian 2014-02-26 09:32:37 UTC

I will work on this task too, if you're ok with that.

Comment 2 Dennis Nienhüser 2014-02-26 09:34:51 UTC

Let's give others a chance to grab it as well :-)
Feel free to claim it when you're done with other tasks though.

Comment 3 Sanjiban Bairagya 2014-02-26 10:15:12 UTC

I want to work on this task

Comment 4 Dennis Nienhüser 2014-02-26 18:58:08 UTC

Git commit d7899fef51a81b98d8284c99783a2e5e552eb8b9 by Dennis Nienhüser, on behalf of Sanjiban Bairagya.
Committed on 26/02/2014 at 18:50.
Pushed by nienhueser into branch 'master'.

equality operators for GDSimpleArrayData, GDData and GDExtendedData

REVIEW: 116084

M  +10   -0    src/lib/marble/geodata/data/GeoDataData.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataData.h
M  +10   -0    src/lib/marble/geodata/data/GeoDataExtendedData.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataExtendedData.h
M  +10   -0    src/lib/marble/geodata/data/GeoDataSimpleArrayData.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataSimpleArrayData.h
M  +65   -0    tests/TestEquality.cpp

http://commits.kde.org/marble/d7899fef51a81b98d8284c99783a2e5e552eb8b9