Bug 331525

Summary:	Implement equality operators for GeoDataBalloonStyle, GeoDataColorStyle and GeoDataCamera
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	Cruceru Calin-Cristian <crucerucalincristian>
Status:	RESOLVED FIXED
Severity:	task	CC:	crucerucalincristian
Priority:	NOR	Keywords:	junior-jobs
Version:	1.8 (KDE 4.13)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/561c57fdbe6e246f602dc5a181d0d423c52e21f0	Version Fixed In:

Description Dennis Nienhüser 2014-02-26 09:24:51 UTC

Add operator== and operator!= to each of the classes GeoDataBalloonStyle, GeoDataColorStyle and GeoDataCamera. Extend tests/TestEquality by a new unit test method for each of the classes which verifies the implementation for several instances of each class.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and run the test case from the build folder (run tests/TestEquality). Note that operator!= should call operator==, see GeoDataAccuracy for an example.

Submit a review request at https://git.reviewboard.kde.org

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.

Comment 1 Cruceru Calin-Cristian 2014-02-26 09:29:08 UTC

I want to work on this task.

Comment 2 Cruceru Calin-Cristian 2014-02-27 00:17:46 UTC

I made a post review with the patch for this BUG: https://git.reviewboard.kde.org/r/116110/
Waiting for feedback.

Comment 3 Dennis Nienhüser 2014-02-27 21:50:21 UTC

Git commit 561c57fdbe6e246f602dc5a181d0d423c52e21f0 by Dennis Nienhüser, on behalf of Cruceru Calin-Cristian.
Committed on 27/02/2014 at 21:30.
Pushed by nienhueser into branch 'master'.

Equality operators for GDBalloonStyle, GDColorStyle and GDCamera

REVIEW: 116110

M  +11   -0    src/lib/marble/geodata/data/GeoDataBalloonStyle.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataBalloonStyle.h
M  +14   -0    src/lib/marble/geodata/data/GeoDataCamera.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataCamera.h
M  +11   -0    src/lib/marble/geodata/data/GeoDataColorStyle.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataColorStyle.h
M  +70   -0    tests/TestEquality.cpp

http://commits.kde.org/marble/561c57fdbe6e246f602dc5a181d0d423c52e21f0