Summary: | Save the "show zoomlevel" setting in marble-qt | ||
---|---|---|---|
Product: | [Applications] marble | Reporter: | Dennis Nienhüser <nienhueser> |
Component: | general | Assignee: | Cruceru Calin-Cristian <crucerucalincristian> |
Status: | RESOLVED FIXED | ||
Severity: | task | CC: | dyr |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 1.7 (KDE 4.12) | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/marble/5815b1651b0f7f643c58aac4d172f8ac51aba510 | Version Fixed In: | 4.13.0 |
Attachments: | patch for the bug331304 |
Description
Dennis Nienhüser
2014-02-19 20:48:31 UTC
I tried to solve the bug and posted a patch to be reviewed for this bug on the reviewboard: https://git.reviewboard.kde.org/r/115924/ Created attachment 85251 [details] patch for the bug331304 This it my first patch solving a bug in marble. If it's something wrong with the patch or some piece of code, please tell me. I want you to be critical so I can grow better skills. The patch works fine, I'll do the following minor changes when pushing: - change "zoomlevel" to "showZoomLevel" for the settings key (camel case and more descriptive) - change "Show zoom level" for the action name to "Show Zoom Level" according to http://techbase.kde.org/Projects/Usability/HIG/Capitalization (this was wrong in the original code) - remove the comment regarding the variable name in the .h file. The confusion comes from the technical term "tile level" used for variable names and "zoom level" for presentation to the user. It's a bit mixed up in the original code, but that's not much a problem @Dyr: I'll go for the other patch since the bug was already assigned, sorry. I'll create more tasks soon. Git commit 5815b1651b0f7f643c58aac4d172f8ac51aba510 by Dennis Nienhüser, on behalf of Cruceru Calin-Cristian. Committed on 21/02/2014 at 09:28. Pushed by nienhueser into branch 'master'. Save the "show zoomlevel" setting in marble-qt FIXED-IN: 4.13.0 M +12 -7 src/apps/marble-qt/QtMainWindow.cpp M +1 -0 src/apps/marble-qt/QtMainWindow.h http://commits.kde.org/marble/5815b1651b0f7f643c58aac4d172f8ac51aba510 |