Bug 330804

Summary: Canvas-Only mode broken in Desktop Mode
Product: [Applications] krita Reporter: Arjen Hiemstra <ahiemstra>
Component: Krita GeminiAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: All   
Latest Commit: http://commits.kde.org/calligra/c975a2ba2922b10438615ffbcbfa384d1e9ec08a Version Fixed In:

Description Arjen Hiemstra 2014-02-05 16:29:18 UTC 
The canvas-only mode in Gemini Desktop mode is currently broken. This is probably due to embedding a KoMainWindow inside a QMainWindow, but I'm not perfectly sure what causes it.

Reproducible: Always

Steps to Reproduce:
1. Start Gemini, make sure to be in Desktop mode.
2. Press "Tab" to switch to canvas-only mode (or use the menu item).
Actual Results:  
A message is displayed "Switching to canvas-only mode." but no actual switch happens.

Expected Results:  
The same message is displayed and then the application is switched to canvas-only mode.
Comment 1 Halla Rempt 2014-02-05 16:36:29 UTC 
Hm, maybe in gemini, tab should go to tablet mode and canvas only mode 
should be hidden?
Comment 2 Arjen Hiemstra 2014-02-17 16:04:47 UTC 
Git commit 2914e6feed77d3273be9328dd91504f4308bbe16 by Arjen Hiemstra.
Committed on 17/02/2014 at 15:20.
Pushed by ahiemstra into branch 'master'.

Make canvas-only mode work in Gemini

Since Gemini embeds the KoMainWindow in a QMainWindow, window() is a
QMainWindow and thus most of the current code breaks. Now we rely less
on this and in addition handle most of the state changes directly rather
than calling actions somewhere else that can have unintended side
effects.

M  +23   -16   krita/ui/kis_view2.cpp

http://commits.kde.org/calligra/2914e6feed77d3273be9328dd91504f4308bbe16
Comment 3 Halla Rempt 2014-02-18 10:17:38 UTC 
Git commit c975a2ba2922b10438615ffbcbfa384d1e9ec08a by Boudewijn Rempt, on behalf of Arjen Hiemstra.
Committed on 17/02/2014 at 15:20.
Pushed by rempt into branch 'calligra/2.8'.

Make canvas-only mode work in Gemini

Since Gemini embeds the KoMainWindow in a QMainWindow, window() is a
QMainWindow and thus most of the current code breaks. Now we rely less
on this and in addition handle most of the state changes directly rather
than calling actions somewhere else that can have unintended side
effects.

M  +23   -16   krita/ui/kis_view2.cpp

http://commits.kde.org/calligra/c975a2ba2922b10438615ffbcbfa384d1e9ec08a