Bug 328070

Summary:	[crop-tool] usability issue when viewport zoomed to a part of the artwork
Product:	[Applications] krita	Reporter:	David REVOY <info>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/adcf8c452dc42049bd8be8aa70079c671b71200a	Version Fixed In:

Description David REVOY 2013-11-25 16:52:05 UTC

A minor report about the crop tool :
1. Create a A4 @ 300ppi ( around 2400x3500 ) 
2. Zoom at 100% on the canvas
3. Draw a little dot or a stickman
4. Try to crop it with the crop tool

Result :
Crop tool widget appear , but is really bigger than the viewport. 
What appear on screen doesn't make sens ( only part of the widget is draw , user has to zoom out to get the crop tool control handle back in viewport  ).

Solution :
I suppose making the crop tool aware of the zoom level , and able to propose a widget always usable.

Comment 1 Dmitry Kazakov 2013-12-03 07:15:07 UTC

Git commit 49dcbabe8c8edeae7139ffc9b1520083e1195e62 by Dmitry Kazakov.
Committed on 03/12/2013 at 07:13.
Pushed by dkazakov into branch 'master'.

Fixed usability issues in the Crop Tool

Here is the list of changes:

1) Now you can restart the crop rect by click-dragging outside
   of the current crop rect. Just start dragging a new rect and
   it will replace the current one.
2) When activating the tool, the crop rect is created automatically
   *only* if you have some global selection active.
3) If you "click" on the image, the whole image will be selected
4) If you "click" outside of the current crop rect, it will be deselected
   automatically

M  +36   -23   krita/plugins/tools/tool_crop/kis_tool_crop.cc
M  +1    -0    krita/plugins/tools/tool_crop/kis_tool_crop.h

http://commits.kde.org/calligra/49dcbabe8c8edeae7139ffc9b1520083e1195e62

Comment 2 David REVOY 2013-12-03 08:09:29 UTC

Thanks Dmitry ! and really clever design you made on it. 
I just played with it ; and I love it.
The one click on canvas to select crop to project border/limits is just perfect.
I also like the new ability to cancel a selection by clicking outside of it. 

I just saw a tiny new bug : it's about the zoom of the canvas in the viewport after cropping ; it break the fix made for this Bug 313489 . i

Comment 3 Dmitry Kazakov 2013-12-05 19:56:29 UTC

Git commit adcf8c452dc42049bd8be8aa70079c671b71200a by Dmitry Kazakov.
Committed on 03/12/2013 at 07:13.
Pushed by dkazakov into branch 'calligra/2.8'.

Fixed usability issues in the Crop Tool

Here is the list of changes:

1) Now you can restart the crop rect by click-dragging outside
   of the current crop rect. Just start dragging a new rect and
   it will replace the current one.
2) When activating the tool, the crop rect is created automatically
   *only* if you have some global selection active.
3) If you "click" on the image, the whole image will be selected
4) If you "click" outside of the current crop rect, it will be deselected
   automatically

M  +36   -23   krita/plugins/tools/tool_crop/kis_tool_crop.cc
M  +1    -0    krita/plugins/tools/tool_crop/kis_tool_crop.h

http://commits.kde.org/calligra/adcf8c452dc42049bd8be8aa70079c671b71200a