Summary: | xulrunner crashes with pencil application | ||
---|---|---|---|
Product: | [Plasma] Oxygen | Reporter: | nucleo <nucleo> |
Component: | gtk2-engine | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | b7.10110111, hugo.pereira.da.costa, maxim.yegorushkin, web |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
debug log
patch |
Description
nucleo
2013-10-09 13:53:53 UTC
What Pencil do you use? I've tried Ubuntu-provided pencil package, it gives me some graphics editor which is apparently Qt-based, so it doesn't crash. Name : pencil Arch : noarch Version : 2.0.4 Release : 3.fc20 Size : 4.3 M Repo : fedora/20/i386 Summary : A sketching and GUI prototyping tool URL : http://code.google.com/p/evoluspencil/ License : GPLv2 Description : Pencil is an open source GUI prototyping and sketching tools released under GPL. another case of undetected xul it seems. investigating ... Can't reproduce here. The application is recognized as xul: ApplicationName::initialize - from pid: xulrunner-bin from gtk: xulrunner-bin ApplicationName::initialize - from pid: xulrunner-bin from gtk: xulrunner-bin internal: XUL (Mozilla) version: 0x0 And I can't see it crash. What's the output at the beginning of the log (corresponding to ApplicationName) when you run with oxygen-gtk compiled in debug mode ? If you can provide the information requested in comment #4, please add it. Created attachment 83170 [details]
debug log
*** Bug 329767 has been marked as a duplicate of this bug. *** Sorry for the late answer Issue here in your case that the pidapplication name is indeed tagged as xulrunner but not the gtk app name: ApplicationName::initialize - from pid: xulrunner from gtk: pencil as opposed to mine: ApplicationName::initialize - from pid: xulrunner-bin from gtk: xulrunner-bin I guess that this varies (damn) depending on the pencil version. Anyway easy fix is to test both app names. Will provide a patch in next comment, in case someone (nucleo ? Maxim ?) can test Hugo Created attachment 84535 [details]
patch
would be nice if someone could compile oxygen-gtk (either master or 1.4 branch) with this patch added and check, since I cannot reproduce the crash myself
once done, I'll commit so that it gets included in the next release (next week).
@maxim if you're willing to test and need help to get the sources, apply the patch, compile and/or install, don't hesitate to ask @hugo, I don't mind compiling and testing, as long as it does not destroy my existing Fedora 20 KDE install ) Point me to the docs, what and how to build, I can apply the patch and compile. well, this will erase your old install of oxygen-gtk2 (but that should not be a big deal) The instructions get the sources from http://kde-look.org/content/show.php/?content=136216 (take the gtk2-1.4.1 version) you need to have dev packages for gtk+-2.0, cairo. You also need cmake and gcc-c++ Then: gtar -xvf oxygen-gtk2-1.4.1.tar.bz2 cd oxygen-gtk2-1.4.1 patch -p1 < pencil.patch mkdir build cd build cmake .. make sudo make install ... should work Until sudo make install, all is safe, you don't break anything. After install this should erase your old version. But you can always roll back don't worry (its a quite tiny library with little dependencies. I applied the patch, compiled and installed. Pencil does not crash on menu open any more. Thanks a lot Hugo. Git commit ae0336220e7d9d10eeba6277ed01764710862624 by Hugo Pereira Da Costa. Committed on 09/01/2014 at 16:00. Pushed by hpereiradacosta into branch '1.4'. Check both pid and gtk app name to identify XUL applications M +1 -1 src/oxygenapplicationname.cpp http://commits.kde.org/oxygen-gtk/ae0336220e7d9d10eeba6277ed01764710862624 @Maxim thanks a lot for testing. Closing the bug. best Hugo |