Summary: | [tag] new tag/group are not accessible after creation | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | David REVOY <info> |
Component: | Usability | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla, sven.langkamp |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/f7d7be74cd418269ac86b398a9f6c7a0ff66abf8 | Version Fixed In: |
Description
David REVOY
2013-09-25 10:48:27 UTC
Yes, I see that happen :-( There is a problem with the way we store tags. A tag is only save if it's associated with a tag, there is no "empty tag". Whatever you add the the top-right dropdown will be lost on the next start. The same also happens if you remove all resource from a tag. Even though the comobox still shows it, it will be gone next time you start Krita. Workaround would be to use only the right-click menu on the presets. Git commit 2923349d74880c6c51392746d8845f2d1e98694a by Boudewijn Rempt. Committed on 11/12/2013 at 14:23. Pushed by rempt into branch 'calligra/2.8'. Remove Nepomuk integration The default was the xml-file backend. The nepomuk ingegration was basically unused, and having everyone use the same backend makes support a lot easier. M +3 -20 CMakeLists.txt M +0 -3 KoConfig.h.cmake M +0 -42 krita/ui/dialogs/kis_dlg_preferences.cc M +0 -4 krita/ui/dialogs/kis_dlg_preferences.h M +1 -44 krita/ui/forms/wdggeneralsettings.ui M +0 -9 libs/widgets/CMakeLists.txt M +0 -10 libs/widgets/KoResourceServer.h M +2 -188 libs/widgets/KoResourceTagging.cpp M +0 -20 libs/widgets/KoResourceTagging.h M +1 -46 libs/widgets/tests/KoResourceTagging_test.cpp M +0 -3 libs/widgets/tests/KoResourceTagging_test.h http://commits.kde.org/calligra/2923349d74880c6c51392746d8845f2d1e98694a Git commit 84ab7d7572b0e2e6eca49a34312d5380e794e2f8 by Boudewijn Rempt. Committed on 11/12/2013 at 14:23. Pushed by rempt into branch 'master'. Remove Nepomuk integration The default was the xml-file backend. The nepomuk ingegration was basically unused, and having everyone use the same backend makes support a lot easier. M +3 -20 CMakeLists.txt M +0 -3 KoConfig.h.cmake M +0 -42 krita/ui/dialogs/kis_dlg_preferences.cc M +0 -4 krita/ui/dialogs/kis_dlg_preferences.h M +1 -44 krita/ui/forms/wdggeneralsettings.ui M +0 -9 libs/widgets/CMakeLists.txt M +0 -10 libs/widgets/KoResourceServer.h M +2 -188 libs/widgets/KoResourceTagging.cpp M +0 -20 libs/widgets/KoResourceTagging.h M +1 -46 libs/widgets/tests/KoResourceTagging_test.cpp M +0 -3 libs/widgets/tests/KoResourceTagging_test.h http://commits.kde.org/calligra/84ab7d7572b0e2e6eca49a34312d5380e794e2f8 Next step: save unused tags in the xml file, then offer a gui to weed out unused tags. Git commit 6396c0ef2d5c67a5a5326debe3450057f0e3bcbe by Boudewijn Rempt. Committed on 16/12/2013 at 20:33. Pushed by rempt into branch 'master'. Make it possible to add tags to a store without adding them to a resource M +2 -2 libs/widgets/CMakeLists.txt M +3 -3 libs/widgets/KoResourceFiltering.cpp M +2 -2 libs/widgets/KoResourceFiltering.h M +14 -14 libs/widgets/KoResourceServer.h M +1 -1 libs/widgets/KoResourceServerAdapter.cpp M +64 -85 libs/widgets/KoResourceServerAdapter.h R +24 -18 libs/widgets/KoResourceTagStore.cpp [from: libs/widgets/KoResourceTagging.cpp - 088% similarity] R +9 -6 libs/widgets/KoResourceTagStore.h [from: libs/widgets/KoResourceTagging.h - 084% similarity] M +2 -0 libs/widgets/KoResourceTaggingManager.cpp M +3 -3 libs/widgets/tests/KoResourceTagging_test.h http://commits.kde.org/calligra/6396c0ef2d5c67a5a5326debe3450057f0e3bcbe Git commit cafd416da7f8f78d8b605f409cfa24ed0087678e by Boudewijn Rempt. Committed on 16/12/2013 at 20:33. Pushed by rempt into branch 'calligra/2.8'. Make it possible to add tags to a store without adding them to a resource M +2 -2 libs/widgets/CMakeLists.txt M +3 -3 libs/widgets/KoResourceFiltering.cpp M +2 -2 libs/widgets/KoResourceFiltering.h M +14 -14 libs/widgets/KoResourceServer.h M +1 -1 libs/widgets/KoResourceServerAdapter.cpp M +64 -85 libs/widgets/KoResourceServerAdapter.h R +24 -18 libs/widgets/KoResourceTagStore.cpp [from: libs/widgets/KoResourceTagging.cpp - 088% similarity] R +9 -6 libs/widgets/KoResourceTagStore.h [from: libs/widgets/KoResourceTagging.h - 084% similarity] M +2 -0 libs/widgets/KoResourceTaggingManager.cpp M +3 -3 libs/widgets/tests/KoResourceTagging_test.h http://commits.kde.org/calligra/cafd416da7f8f78d8b605f409cfa24ed0087678e Git commit e0439572c2088e30831359857f75395f9b6309d9 by Boudewijn Rempt. Committed on 17/12/2013 at 10:22. Pushed by rempt into branch 'master'. Show newly created tags in the context menus There's still a bit of a mess, in that deleted unused tags aren't cleaned up, so we'll need a cleanup feature for that. M +14 -17 libs/widgets/KoResourceItemChooserContextMenu.cpp M +2 -1 libs/widgets/KoResourceModel.cpp M +4 -5 libs/widgets/KoResourceTaggingManager.cpp M +2 -0 libs/widgets/KoTagChooserWidget.cpp http://commits.kde.org/calligra/e0439572c2088e30831359857f75395f9b6309d9 Git commit f7d7be74cd418269ac86b398a9f6c7a0ff66abf8 by Boudewijn Rempt. Committed on 17/12/2013 at 10:22. Pushed by rempt into branch 'calligra/2.8'. Show newly created tags in the context menus There's still a bit of a mess, in that deleted unused tags aren't cleaned up, so we'll need a cleanup feature for that. M +14 -17 libs/widgets/KoResourceItemChooserContextMenu.cpp M +2 -1 libs/widgets/KoResourceModel.cpp M +4 -5 libs/widgets/KoResourceTaggingManager.cpp M +2 -0 libs/widgets/KoTagChooserWidget.cpp http://commits.kde.org/calligra/f7d7be74cd418269ac86b398a9f6c7a0ff66abf8 |