Bug 324505

Summary:	filter-layers opacity don't work anymore
Product:	[Applications] krita	Reporter:	animtim
Component:	Filter Layers	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/fc3fcc743d9706f13167b7317fdfb10c02fce7a9	Version Fixed In:

Description animtim 2013-09-04 16:00:44 UTC

Filter layers opacity don't work anymore. 
No problem with the slider here, just changing the filter layer opacity doesn't make any change on canvas, but I'm quite sure it used to work before.

NOTE: I just noticed it's because now filter layers are always created with copy mode by default.
If I set it back to normal blend mode, opacity works again.

Reproducible: Always

Steps to Reproduce:
1.draw something
2.create a filter layer on top of it (any type of filter, like blur or pixelize are good to see this)
3.set the filter layer's opacity to 50% or even 0% : it makes no change on the canvas.

Comment 1 Halla Rempt 2013-09-28 10:31:18 UTC

Yeah... We have been discussing the default blending mode for filter layers for years now, and we always go back and forth:

commit 04420efd8b44ae8745632de8c1180abd5f5edfd3
Author:     Dmitry Kazakov <dimula73@gmail.com>
AuthorDate: Sat Oct 27 17:44:01 2012 +0400
Commit:     Dmitry Kazakov <dimula73@gmail.com>
CommitDate: Sat Oct 27 18:13:41 2012 +0400

    By default Adjustment Layers should have COMPOSITE_COPY op
    
    Otherwise it makes users perplexed with the result.
    
    BUG:294122

I think we should just keep it this way.

Comment 2 Halla Rempt 2013-09-28 10:53:15 UTC

Git commit 85a9c7761bea895ba235c284b868e794b39168dd by Boudewijn Rempt.
Committed on 28/09/2013 at 10:52.
Pushed by rempt into branch 'master'.

Add links to two bugs for documentation purposes.

These bugs explain the dilemma of which blending mode to make
default for filter layers.
Related: bug 294122

M  +3    -0    krita/image/kis_adjustment_layer.cc

http://commits.kde.org/calligra/85a9c7761bea895ba235c284b868e794b39168dd

Comment 3 Dmitry Kazakov 2015-06-18 08:34:50 UTC

Git commit fc3fcc743d9706f13167b7317fdfb10c02fce7a9 by Dmitry Kazakov.
Committed on 18/06/2015 at 08:30.
Pushed by dkazakov into branch 'calligra/2.9'.

Fix Adjustment layers composition

This was a very old bug related the way how selection is applied
to adjustment layers. Now selection defines not "how the filtered
data is blended into the image" but "how the filter effect is applied
to the composed image". In the result, erasing the selection now will
*not* make your image fully transparent, but just removes the filter
effect from that area.
Related: bug 294122, bug 349078
CC:kimageshop@kde.org

M  +2    -1    krita/image/kis_adjustment_layer.cc
M  +19   -3    krita/image/kis_async_merger.cpp
M  +39   -25   krita/image/kis_selection_based_layer.cpp
M  +21   -0    krita/image/kis_selection_based_layer.h

http://commits.kde.org/calligra/fc3fcc743d9706f13167b7317fdfb10c02fce7a9