| Summary: | in Preferences > Transparency Checkboxes the 'color' doesn't work | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | David REVOY <info> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/a7eaeeb5c5a8b77855b1cf554f5baafb7582630c | Version Fixed In: | |
| Attachments: | screenshot of the issue. Color selected is Pink , checkboxes are white+grey25% | ||
For the qpainter canvas, the change is reflected immediately, for the opengl canvas only when we create a new opengl canvas. Git commit a7eaeeb5c5a8b77855b1cf554f5baafb7582630c by Boudewijn Rempt. Committed on 28/09/2013 at 11:07. Pushed by rempt into branch 'master'. Allow the check colors to be configured independently And make opengl canvas update the check texture when the config changes. M +5 -4 krita/ui/canvas/kis_canvas_widget_base.cpp M +6 -3 krita/ui/dialogs/kis_dlg_preferences.cc M +29 -26 krita/ui/forms/wdgdisplaysettings.ui M +12 -2 krita/ui/kis_config.cc M +6 -2 krita/ui/kis_config.h M +3 -0 krita/ui/opengl/kis_opengl_canvas2.cpp http://commits.kde.org/calligra/a7eaeeb5c5a8b77855b1cf554f5baafb7582630c Nice, thanks ! I updated and see the options. I can't test due to a a bug I just added ( Bug 325387 ) but as soon as it will be possible I 'll do. Thanks Boud for fixing this fast Bug 325387 ; so I could test the two colors new setup option. They work well ; exept the 2 boxes on the preferences panel always reset to both same color. To reproduce : 1. Open the preferences; change the 2 checkbox colors ; all is fine ; Press Ok 2. Erase a bit the flat canvas to see the effect ; transparency checker is similar as 2 checkbox colors 3. Re-Open preferences : #bug# the 2 checkbox colors have similar color. 4. If user press ok ; transparency checker become a flat color. ( so, it force user to setup it each time something in 'Preferences > Display' is changed ) |
Created attachment 82148 [details] screenshot of the issue. Color selected is Pink , checkboxes are white+grey25% The bug affect 'color' selection in Preferences > Transparency Checkboxes If you set a color and press ok , the canvas doesn't reflect the change. Size works well. Also, I would expect the color selected to be the bright tone of the checker (ex: default=white ) ; and the second darker tone be computed relatively ( ex: - 25% value ).