Summary: | TextChannelProxyWatcher cannot recover existing channels correctly | ||
---|---|---|---|
Product: | [Frameworks and Libraries] telepathy | Reporter: | David Edmundson <kde> |
Component: | common-internals | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mklapetek |
Priority: | NOR | ||
Version: | git-latest | ||
Target Milestone: | Future | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/telepathy-contact-list/7e4aaf55d4834381dc1e272e953302d7c78c5942 | Version Fixed In: | 0.9.0 |
Description
David Edmundson
2013-06-01 13:56:57 UTC
The libkpeople mode should have the ability to fix this, we will now have all contactIds and accountIDs loaded when the client observer loads. To reproduce: have someone message you (don't accept the message!) confirm you see an envelope in the contact list restart contact list we want to still see an envelope flashing. Right now it's broken because I try and match ContactPtr objects between the channel and the model, if instead we match contactIDs it /should/ work. Git commit ea0b98887b07de0318a97dc2d04bb7691bac522a by Martin Klapetek. Committed on 11/04/2014 at 15:21. Pushed by mklapetek into branch 'master'. Match contacts in watcher proxy by contact id instead of ContactPtr M +1 -1 KTp/Models/text-channel-watcher-proxy-model.cpp http://commits.kde.org/telepathy-common-internals/ea0b98887b07de0318a97dc2d04bb7691bac522a Git commit 7e4aaf55d4834381dc1e272e953302d7c78c5942 by Martin Klapetek. Committed on 11/04/2014 at 15:22. Pushed by mklapetek into branch 'master'. Delay setting trackUnreadMessages only after we have the model init'd Reviewed-by: David Edmundson M +0 -1 contact-list-widget.cpp M +2 -0 main-widget.cpp http://commits.kde.org/telepathy-contact-list/7e4aaf55d4834381dc1e272e953302d7c78c5942 Git commit 265a352a1832f920950777e75400f6f1fbf7e72b by Martin Klapetek. Committed on 11/04/2014 at 15:21. Pushed by mklapetek into branch 'kde-telepathy-0.8'. Match contacts in watcher proxy by contact id instead of ContactPtr M +1 -1 KTp/Models/text-channel-watcher-proxy-model.cpp http://commits.kde.org/telepathy-common-internals/265a352a1832f920950777e75400f6f1fbf7e72b |