Summary: | notes plasmoid has unreadable text by default on certain plasma themes | ||
---|---|---|---|
Product: | [Plasma] plasma4 | Reporter: | Wolfgang Bauer <wbauer1> |
Component: | widget-notes | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | |
Priority: | NOR | ||
Version: | 4.10.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdeplasma-addons/dfc81cd32181f3f6cb4160bc74bb8d1bee76c1f2 | Version Fixed In: | 4.10.5 |
Description
Wolfgang Bauer
2013-05-27 13:40:00 UTC
(In reply to comment #0) > I will prepare a patch for this on reviewboard. Done: https://git.reviewboard.kde.org/r/110701/ Git commit 0e0b98c373a8fd68e1fb4bcb1219b62092ad5cc4 by Wolfgang Bauer. Committed on 25/06/2013 at 19:13. Pushed by wbauer into branch 'KDE/4.10'. Make the notes plasmoid change the background color according to the current plasma theme's text color The notes plasmoid by default takes the text color from the current plasma theme but has "yellow" hardcoded as default background color. This can lead to unreadable notes by default with certain plasma themes, e.g. Produkt. It's especially annoying if you're using such a theme because you can't globally change the default notes colors but have to do it for each note on its own (f.e. every time after pasting text to the desktop by pressing the middle mouse button). This patch changes the default background color to black if the text color is brighter than a certain threshold. Also the background color is re-read from the config on plasma theme change to make it change as well if necessary. FIXED-IN: 4.10.5 REVIEW: 110701 M +11 -2 applets/notes/notes.cpp http://commits.kde.org/kdeplasma-addons/0e0b98c373a8fd68e1fb4bcb1219b62092ad5cc4 Git commit dfc81cd32181f3f6cb4160bc74bb8d1bee76c1f2 by Wolfgang Bauer. Committed on 25/06/2013 at 19:39. Pushed by wbauer into branch 'master'. Make the notes plasmoid change the background color according to the current plasma theme's text color The notes plasmoid by default takes the text color from the current plasma theme but has "yellow" hardcoded as default background color. This can lead to unreadable notes by default with certain plasma themes, e.g. Produkt. It's especially annoying if you're using such a theme because you can't globally change the default notes colors but have to do it for each note on its own (f.e. every time after pasting text to the desktop by pressing the middle mouse button). This patch changes the default background color to black if the text color is brighter than a certain threshold. Also the background color is re-read from the config on plasma theme change to make it change as well if necessary. REVIEW: 110701 M +11 -2 applets/notes/notes.cpp http://commits.kde.org/kdeplasma-addons/dfc81cd32181f3f6cb4160bc74bb8d1bee76c1f2 Just to make sure: About what notes plasmoid are we talking? The normale one, that exists since KDE 4.1 or so? Or the akonadi notes plasmoid that exists since KDE 4.8 or 4.9? Because of thi first one I can change the color (background + text) without any problems. The akonadi plasmoid always has a yellow background, which is indeed annoying. But even with KDE 4.10.5 the text color is white (with a dark thema), so the patch doesn't seem to work. Anyway, I would prefer to be able to change the background color of the plasmoid, because this is why we have plasma themes and this plasmoid is the only one I know with a fixed background color. (In reply to comment #4) > Just to make sure: About what notes plasmoid are we talking? > The normale one, that exists since KDE 4.1 or so? Or the akonadi notes > plasmoid that exists since KDE 4.8 or 4.9? This is about the normal notes plasmoid (I don't remember since when this exists). The one you get if you paste some text to the desktop (click on an empty space on the desktop with the middle mouse button) > Because of thi first one I can change the color (background + text) without > any problems. That's true, but it had yellow as default. And the text color from the current plasma theme. So if you use a (dark) theme with a bright text color, you get an unreadable note on the desktop, so you had to change the text or background color for each one separately (there is no global way to change this). This is what is fixed now. The default background color is now black (instead of yellow) if the text color is bright. > The akonadi plasmoid always has a yellow background, which is > indeed annoying. But even with KDE 4.10.5 the text color is white (with a > dark thema), so the patch doesn't seem to work. > > Anyway, I would prefer to be able to change the background color of the > plasmoid, because this is why we have plasma themes and this plasmoid is the > only one I know with a fixed background color. For the akonotes plasmoid you should open a new bug. Ok, I see. Thanks for clarification. :-) |