Summary: | KMail uses a wrong autocorrection filename | ||
---|---|---|---|
Product: | [Applications] kmail2 | Reporter: | André Marcelo Alvarenga <alvarenga> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | montel |
Priority: | NOR | ||
Version: | 4.10.2 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdepim/86b9f742a7c12dd0ad7c30de98e47de52ebc1f21 | Version Fixed In: | 4.11 |
Description
André Marcelo Alvarenga
2013-05-21 04:02:10 UTC
wierd. Will look at it soon In identity which language do you use as autocorrection ? (In reply to comment #2) > In identity which language do you use as autocorrection ? when I wrote the bug report, autocorrect language was empty (not defined), since I was running KDE in a virtual machine. Changing to Brazilian Portuguese (Português do Brasil), I deleted /home/user/.kde/share/apps/autocorrect/custom-pt_BR.xml file and tested again, but the problem remains. KMail is still using: /usr/share/kde4/apps/autocorrect/pt.xml instead of: /usr/share/kde4/apps/autocorrect/pt_BR.xml I'm not a developer and maybe I'm wrong, but see this part of the code: /calligra/plugins/textediting/autocorrection/Autocorrect.cpp Line: 743 Q_FOREACH(const QString& path, folders) { if (!m_autocorrectLang.isEmpty()) fname = KGlobal::dirs()->findResource("data", path + "autocorrect/" + m_autocorrectLang + ".xml"); if (m_autocorrectLang != "all_languages") { if (fname.isEmpty() && !kdelang.isEmpty()) fname = KGlobal::dirs()->findResource("data", path + "autocorrect/" + kdelang + ".xml"); if (fname.isEmpty() && kdelang.contains("_")) { kdelang.remove( QRegExp( "_.*" ) ); fname = KGlobal::dirs()->findResource("data", path + "autocorrect/" + kdelang + ".xml"); } } if(!fname.isEmpty()) { readAutocorrectXmlEntry(fname, false); break; } } This is correct? calligra ?:) kmail ?:) it's not the same code. I can't reproduce for the moment your problem. Here it works fine when I use pt_BR Will continue to investigate it (In reply to comment #4) > calligra ?:) kmail ?:) > it's not the same code. > I can't reproduce for the moment your problem. Here it works fine when I use > pt_BR > Will continue to investigate it I thought KMail wore the same code Calligra autocorrection plugin, sorry. However, there is a similar code in kdepim/messagecomposer/autocorrection/composerautocorrection.cpp. I will try a screencast with the problem. I recorded a screencast with the problem: http://youtu.be/XZyoQ_goDjU Thanks for screencast. Yes there is a bug in your system. When it select pt.xml in your .emailidentities which is "Autocorrection Language" entry ? Git commit 86b9f742a7c12dd0ad7c30de98e47de52ebc1f21 by Montel Laurent. Committed on 06/06/2013 at 08:01. Pushed by mlaurent into branch 'master'. Fix Bug 320074 - KMail uses a wrong autocorrection filename FIXED-IN: 4.11 M +8 -1 messagecomposer/autocorrection/composerautocorrectionwidget.cpp M +1 -0 messagecomposer/autocorrection/composerautocorrectionwidget.h http://commits.kde.org/kdepim/86b9f742a7c12dd0ad7c30de98e47de52ebc1f21 It's working now. Thanks for fixing. |