Bug 319369

Summary:	Use adblock for Kmail
Product:	[Applications] kmail2	Reporter:	m.wege
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	jsardid, montel
Priority:	NOR
Version:	4.10.2
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	4.12

Description m.wege 2013-05-05 16:12:20 UTC

Just discovered that Thunderbird allows to use adblock. I would love to see it in Kmail too. Blocking adds and tracking stuff while still being able to have a look at HTML-mails sounds like a good idea. Since adblock is already part of KDE used in Konqueror and Rekonq, would it be possile just to actived and configure it in Kmail too? I am not sure if it is already used in Kmail since I guess Kmail uses either webkit oder KHTML to display HTML-mails. If so, some configuration in Kmail would make sense which for example would allow to temporally deactivate it on per site/sender basis.

Reproducible: Always

Comment 1 Laurent Montel 2013-05-06 05:20:05 UTC

We can't use it, we use directly kwebview which doesn't support it.
Regards

Comment 2 m.wege 2013-05-06 06:31:10 UTC

Does it make sense then to reassign this to Kwebview or isn't it designed for something like adblock?

Comment 3 Laurent Montel 2013-05-06 07:52:14 UTC

no I don't think that it's for kwebview directly.
it's implemented in kwebkitpart.

After that moving in kwebview will good but don't know if it's possible

Comment 4 Laurent Montel 2013-09-25 19:49:30 UTC

Git commit 289ecd2daeeeab28337c831e1a35ca37bbbf1a3d by Montel Laurent.
Committed on 25/09/2013 at 19:48.
Pushed by mlaurent into branch 'master'.

Start to add adblock support

M  +1    -1    messageviewer/CMakeLists.txt
A  +152  -0    messageviewer/adblock/networkaccessmanager.cpp     [License: LGPL (v2.1+)]
A  +54   -0    messageviewer/adblock/networkaccessmanager.h     [License: LGPL (v2.1+)]
A  +40   -0    messageviewer/adblock/webpage.cpp     [License: GPL (v2)]
A  +32   -0    messageviewer/adblock/webpage.h     [License: GPL (v2)]
M  +4    -0    messageviewer/settings/messageviewer.kcfg.cmake
M  +5    -1    messageviewer/viewer/mailwebview_webkit.cpp

http://commits.kde.org/kdepim/289ecd2daeeeab28337c831e1a35ca37bbbf1a3d

Comment 5 Laurent Montel 2013-09-28 10:16:47 UTC

Fixed in 4.12.

I added a lot of features compares to rekonq settings etc.
I will continue to implement it until 4.12
Regards

Comment 6 m.wege 2013-09-28 11:41:13 UTC

Great, thanks for doing this.

Comment 7 avlas 2017-02-01 19:25:21 UTC

Not sure how much demanding this would be, but it would be great to port adblock to webengine. It would be neat to have it in kmail and akregator (as well as konqueror)