Summary: | triple-click with very long lines only selects part that is visible | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Jonathan Marten <jjm> |
Component: | copy-paste | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | cheecheeo, yyc1992 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/konsole/914067d14a6a27b59bba1c53cc18cb67eb9811fc | Version Fixed In: | 2.13 |
Attachments: |
Screen shot - original state before click
Screen shot - after triple click Screen shot - after scrolling down |
Description
Jonathan Marten
2013-05-03 08:41:32 UTC
Created attachment 79656 [details]
Screen shot - original state before click
Created attachment 79657 [details]
Screen shot - after triple click
Created attachment 79658 [details]
Screen shot - after scrolling down
Same problem here. And this not only affects triple click, it affects double click selection as well if that word happens to be partially outside visible region. The problem seems to be the internal function for selecting text cannot handle starting (and ending) a selection out of visible region? Yes that appears to be case. Review request submitted. https://git.reviewboard.kde.org/r/111441/ Git commit 0b69bdcd40d93d9b87b729a978974b1cc2a77b35 by Kurt Hindenburg. Committed on 12/01/2014 at 18:51. Pushed by hindenburg into branch 'master'. Fix double click can only select text within visible region Double-clicking on text will highlight text not on the visible screen. This is the 2nd part of this patch. The first part for triple clicking highlighting the entire line is already in 2.12. Thanks to Yichao Yu yyc1992@gmail.com for this big patch. REVIEW: 111441 FIXED-IN: 2.13 M +140 -124 src/TerminalDisplay.cpp M +2 -0 src/TerminalDisplay.h http://commits.kde.org/konsole/0b69bdcd40d93d9b87b729a978974b1cc2a77b35 Git commit 914067d14a6a27b59bba1c53cc18cb67eb9811fc by Kurt Hindenburg. Committed on 12/01/2014 at 18:51. Pushed by hindenburg into branch 'frameworks'. Fix double click can only select text within visible region Double-clicking on text will highlight text not on the visible screen. This is the 2nd part of this patch. The first part for triple clicking highlighting the entire line is already in 2.12. Thanks to Yichao Yu yyc1992@gmail.com for this big patch. REVIEW: 111441 FIXED-IN: 2.13 (cherry picked from commit 0b69bdcd40d93d9b87b729a978974b1cc2a77b35) M +140 -124 src/TerminalDisplay.cpp M +2 -0 src/TerminalDisplay.h http://commits.kde.org/konsole/914067d14a6a27b59bba1c53cc18cb67eb9811fc |