Bug 317902

Summary:	JJ: Amarok should issue a warning when transcoding is not possible when ffmpeg is not installed
Product:	[Applications] amarok	Reporter:	Stefan Brüns <stefan.bruens>
Component:	Transcoding	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aseemkapoor88, matej, me, ravm1980, teo
Priority:	NOR	Keywords:	junior-jobs
Version:	2.7.0
Target Milestone:	2.8
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/amarok/d42e43fbd5bdcb1a75bb7891f3248597daefe86f	Version Fixed In:	2.9

Description Stefan Brüns 2013-04-05 21:44:43 UTC

On a system without ffmpeg, "Copy to collection" directly transfers the songs to the device (UMS/MTP). There is no information how to activate transcoding.
Even the Help/Diagnostics does not mention ffmpeg at all.

Reproducible: Always

Comment 1 Matěj Laitl 2013-04-06 10:41:48 UTC

Hmm, you're right. We should show the Transcoding dialog unconditionally, users can check "always copy" so that this won't cause nuisance for those who don't care about transcoding.

Making this a junior job; let's add a note (QLabel) to transcoding dialog when no encoder is found (more general than just ffmpeg not found; similar to mood file generation note in Amarok Config -> General) and show the Transcode dialog even if no encoder has been found.

Comment 2 Aseem 2013-04-09 15:59:25 UTC

Hi Stefan and Matej!

I would like to work on this bug. As this is the first time I am trying to contribute to open source, please help me with getting started. Currently I don't have linux installed on my machine, would it be a hurdle while working on this bug? And also, please let me know where to find the code. 

Thanks in advance.

Comment 3 Myriam Schweingruber 2013-04-09 16:16:17 UTC

Hi Assem,

to work on bugs you need to be able to build and test the latest code, and that currently only works well with Linux, especially for beginners as it is quite tricky to build Amarok from source in Windows. Especially if you aim to participate in the GSoC you definitely should use a Linux installation. You will also need a recent KDE installation. Please have a look at the documentation in http://community.kde.org/Amarok/Development/Join, all information you need is there.

Comment 4 Myriam Schweingruber 2013-04-09 16:18:28 UTC

(In reply to comment #3)
> Hi Assem,

Sorry, Aseem, I didn't intend to mangle your name :(

Comment 5 René Alberto Viant Morán 2013-06-27 22:06:32 UTC

Hi all,
 If there is nobody working on this bug I'd like to give a try. I'm also kind of new in open source coding so any help you guys can give me will be awesome. Thanks in advance!

Comment 6 Jai Luthra 2013-10-18 20:38:48 UTC

I am trying to fix this bug. This is my first bug fix so I might need help.
Hopefully, a patch will be up for review soon :-)

Comment 7 Myriam Schweingruber 2013-10-19 01:54:44 UTC

Jai: if you need help, please send your questions to the amarok-devel@kde.org mailing list, and please submit your patch to http://reviewboard.kde.org, group: amarok

Comment 8 Jai Luthra 2013-10-19 07:36:28 UTC

Thanks Myriam :-)
Here's the patch https://git.reviewboard.kde.org/r/113346/

Comment 9 Matěj Laitl 2013-10-22 10:14:04 UTC

Git commit d42e43fbd5bdcb1a75bb7891f3248597daefe86f by Matěj Laitl, on behalf of Jai Luthra.
Committed on 22/10/2013 at 09:55.
Pushed by laitl into branch 'master'.

BugFix: 317902 - Issue a warning when transcoding is not possible

When ffmpeg is not available, the transcoding dialog will not be skipped;
rather it will add a note for the user to install an encoder.
REVIEW: 113346
FIXED-IN: 2.9
CCMAIL: Jai Luthra <me@jailuthra.in>

M  +2    -0    ChangeLog
M  +0    -6    src/core/collections/CollectionLocation.cpp
M  +5    -0    src/transcoding/TranscodingAssistantDialog.cpp
M  +10   -0    src/transcoding/TranscodingAssistantDialog.ui

http://commits.kde.org/amarok/d42e43fbd5bdcb1a75bb7891f3248597daefe86f