| Summary: | URL bar can't handle fast-typing | ||
|---|---|---|---|
| Product: | [Applications] rekonq | Reporter: | Qumeric |
| Component: | general | Assignee: | Andrea Diamantini <adjam7> |
| Status: | RESOLVED UNMAINTAINED | ||
| Severity: | normal | CC: | apcomptec, asturm, daniel.anken, david, forenhampel, jb, leszek.lesner, luca76, matt.scheirer, zilti |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | 3.0 | ||
| Platform: | Chakra | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | A patch attempt to fix it | ||
|
Description
Qumeric
2013-03-11 16:36:38 UTC
Right... *** Bug 317639 has been marked as a duplicate of this bug. *** *** Bug 318894 has been marked as a duplicate of this bug. *** I have the same issue... Same issue for me (testing it right now with the latest git build, on Arch Linux). Very annoying ! ;-P Me too. Here a demonstration video: http://youtu.be/IAH-KXN2hZE I analyzed the code and found the culprit. Its the suggestUrls() function which slows everything down. I commented it out and everything worked as it should. So I guess this suggestUrls() function aswell as the completionwidget.cpp should be given lesser priority when it comes to typed in urls. So a filter is needed that detects foobar.xyz and when enter is pressed instead of loading the first suggestion of the completionwidget it just loads the typed in url. well... it's quite normal it is the suggestUrls giving problems. But it also gives an important feature (as the name "suggests", it tries to guess the typed url and suggest it accordingly). It is used only when the url is typed in because when e.g. you click somewhere on a link you don't need to guess the url you wanna load. I agree it gives an important feature, but it shouldn't get in the way of the fast-typing user ;) I don't agree that this is normal. Especially as other browsers can do this fine without having the problem described in this bug (i.e. chromium). So there must be a way to optimize this somehow. Created attachment 81398 [details]
A patch attempt to fix it
I tried fixing this issue and I think I got it solved. Not 100 percently but it works at least for me here on my testing machines.
I can still can trigger this issue however on startup when typing in the url before seeing the urlbar and hitting enter. I hope that no one types so fast to trigger this problem. ( I really did lots and lots of tests here but I guess my machine 6 core amd + 16 GB RAM is a little bit oversized for this)
I would love to here from you people if this patch improves/solves the situation for you. It would be cool if it would do this as the patch is very very small :P
Very cool, thanks for the patch! Successfully tested on my old 2-core 1.86ghz + 4 GB RAM Thinkpad. ;) Git commit 5f13021dbc94c13336deb1d2a4849908c9db231e by Andrea Diamantini, on behalf of Mikhail Krutov. Committed on 23/01/2014 at 14:47. Pushed by adjam into branch 'master'. Get sure fast typing work! Related: bug 321967 REVIEW: 115223 REVIEWED-BY: adjam (PS: Many thanks for this, Mikhail...) M +3 -3 src/urlbar/urlbar.cpp M +1 -1 src/urlbar/urlbar.h http://commits.kde.org/rekonq/5f13021dbc94c13336deb1d2a4849908c9db231e I guess this... is solved then? :) Although I'd swear this bug struck again a couple of weeks ago, it seems to be fixed in 2.4.2, Arch Linux, x64, KDE 4.13. I haven't updated since then, but right now it's behaving on this respect :) (In reply to ZRDO from comment #15) > Although I'd swear this bug struck again a couple of weeks ago, it seems to > be fixed in 2.4.2, Arch Linux, x64, KDE 4.13. I haven't updated since then, > but right now it's behaving on this respect :) This bug will still happen if you don't have a complete URL - it passes the incompete text to the autosearch resolver. IE, try typing "a sentence really fast" into the url bar, and it will use your default search provider with something like "a sentence really fa" whereas typed complete urls like www.google.com work. Bug is still here in rekonq's last version (2.4.2). You can reproduce by typing an url that is not known to the autosearch. Pressing "Enter" just after the last letter, it is easily reproducible. Does not happen in Konqueror. Development on Rekonq ceased four years ago, and it has been unmaintained since then. KDE recommends using Falkon instead. |