Bug 311548

Summary: Potential infinite loop
Product: [Frameworks and Libraries] telepathy Reporter: David Edmundson <kde>
Component: kded-moduleAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 0.5.1   
Target Milestone: Future   
Platform: unspecified   
OS: Linux   
Latest Commit: http://commits.kde.org/telepathy-kded-module/3277a4ada099b17a1e6d477f52181436d0d4410b Version Fixed In: 0.5.2

Description David Edmundson 2012-12-12 00:53:47 UTC 
The kded module has a while loop in ContactRequestHandler::onContactRequestDenied which reads

while (i != list.constEnd()) {
  if (valid) {
     it++
  }
}

The it++ should obviously be outside the if.
Comment 1 David Edmundson 2012-12-12 00:56:23 UTC 
Git commit 3277a4ada099b17a1e6d477f52181436d0d4410b by David Edmundson.
Committed on 12/12/2012 at 01:54.
Pushed by davidedmundson into branch 'kde-telepathy-0.5'.

Fix potential infinite loop denying a contact

M  +1    -1    contact-request-handler.cpp

http://commits.kde.org/telepathy-kded-module/3277a4ada099b17a1e6d477f52181436d0d4410b