Summary: | image preview plugin don't use KDE proxy settings | ||
---|---|---|---|
Product: | [Frameworks and Libraries] telepathy | Reporter: | Jonathan D. <jonathand131> |
Component: | text-ui | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | dvratil, kde, mklapetek |
Priority: | NOR | ||
Version: | 0.5.1 | ||
Target Milestone: | Future | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/telepathy-text-ui/f7bd4188bb0b8877f77b303d9e8931885c42536d | Version Fixed In: | 0.6.1 |
Description
Jonathan D.
2012-12-07 12:34:15 UTC
Changing superclass of AdiumThemeView from QWebView to KWebView might fix the problem. Does any dev have proxy settings to try it? Docs for KWebPage indicate that you're right. "This is a convenience class that provides full integration with KDE technologies such as KIO for network request handling" We didn't use it at the time of writing, because we didn't use anything that involved external web requests. I don't have a proxy, but I suggest if we make change and we mark this as resolved->fixed and the original reporter can re-open the bug if it doesn't work. I've made the fix locally, will test for a bit to make sure nothing is broken, then will upload the patch for review. It is OK for me since it is a minor bug. Git commit f7bd4188bb0b8877f77b303d9e8931885c42536d by Martin Klapetek. Committed on 11/04/2013 at 15:37. Pushed by mklapetek into branch 'kde-telepathy-0.6'. Use KWebView instead of QWebView for AdiumThemeView This should make sure that network requests like downloading image preview go through KDE's configured proxy. Reviewed-by: David Edmundson FIXED-IN: 0.6.1 M +1 -1 lib/CMakeLists.txt M +1 -1 lib/adium-theme-view.cpp M +2 -2 lib/adium-theme-view.h M +2 -2 logviewer/CMakeLists.txt http://commits.kde.org/telepathy-text-ui/f7bd4188bb0b8877f77b303d9e8931885c42536d Jonathan, please test (either update from git or wait or 0.6.1) and let us know! Thanks. I am not able to test from git at my work but I will let you know as soon as I have the 0.6.1 installed. |