Summary: | Provide a --sigill-diagnostics flag to suppress illegal instruction reporting | ||
---|---|---|---|
Product: | [Developer tools] valgrind | Reporter: | Mark Wielaard <mark> |
Component: | general | Assignee: | Julian Seward <jseward> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | philippe.waroquiers |
Priority: | NOR | ||
Version: | 3.9.0.SVN | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
VEX part of sigill_diag patch
coregrind and doc part of sigill_diag patch VEX part of sigill_diag patch coregrind, doc and help part of sigill_diag patch coregrind, doc, help and test part of sigill_diag patch |
Description
Mark Wielaard
2012-11-02 14:39:29 UTC
Created attachment 74934 [details]
VEX part of sigill_diag patch
Created attachment 74935 [details]
coregrind and doc part of sigill_diag patch
Quick review on irc by sewardj, about the global variable .. Bool vex_sigill_diag = True; - global vars .. if we ever go MT one day, they will become a major pira - basically this extra bool needs to passed from the central coordination department (main_main.c) to the front ends (xx_toIR.c) - this bool you could get it passed through to the front ends without a global var, at the cost of tiresome plumbing to do more parameter passing through bb_to_IR (or whatever its called) Will adapt the patch to do that. (In reply to comment #3) Also, would be nice to add the new option in the --help output (probably in the uncommon user options) Created attachment 75002 [details] VEX part of sigill_diag patch Updated version that passes through the sigill_diag Bool to the front ends without using a global var as suggested in comment #3. Created attachment 75003 [details] coregrind, doc and help part of sigill_diag patch Updated patch that includes help text as suggested in comment #4. Created attachment 75004 [details]
coregrind, doc, help and test part of sigill_diag patch
Even more updated patch that adds the correct exp for cmdline1 and cmdline2 tests for the new --help text.
Committed, r13164, r2582. Thanks. |