Summary: | all Activities switcher thumbnails are the same; no new Activity can be selected | ||
---|---|---|---|
Product: | [Plasma] Active | Reporter: | Carl Symons <carlsymons> |
Component: | Contour activity switcher | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | active, thomas.pfeiffer |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | unscheduled | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-runtime/88463eabb8c45c91778f5d97991467e08dc28a53 | Version Fixed In: |
Description
Carl Symons
2012-10-09 00:08:21 UTC
I can confirm this with RC1 and updates from last night. Definitely a blocker :( i can replicate this on my test build on the laptop as well. looking into it now... (and i have a suspicion as to what it might be) Git commit b7f490bd6b6e0d12d60573b4316e2931b0dc51f0 by Aaron Seigo. Committed on 09/10/2012 at 11:17. Pushed by aseigo into branch 'KDE/4.9'. dataengine based models set their roles when setting the data, so respond to that syncRoleNames is fast (and faster now that we check that the role names actually changed) but it may be nicer to find a more efficient way in future than checking the role names on all / any data changes. in fact, the documentation for QAbstractItemModel::setRoleNames says: "This function must be called before the model is used. Modifying the role names after the model has been set may result in undefined behaviour." M +5 -5 plasma/declarativeimports/core/datamodel.cpp http://commits.kde.org/kde-runtime/b7f490bd6b6e0d12d60573b4316e2931b0dc51f0 Git commit 88463eabb8c45c91778f5d97991467e08dc28a53 by Aaron Seigo. Committed on 09/10/2012 at 11:17. Pushed by aseigo into branch 'master'. dataengine based models set their roles when setting the data, so respond to that syncRoleNames is fast (and faster now that we check that the role names actually changed) but it may be nicer to find a more efficient way in future than checking the role names on all / any data changes. in fact, the documentation for QAbstractItemModel::setRoleNames says: "This function must be called before the model is used. Modifying the role names after the model has been set may result in undefined behaviour." M +5 -5 plasma/declarativeimports/core/datamodel.cpp http://commits.kde.org/kde-runtime/88463eabb8c45c91778f5d97991467e08dc28a53 Git commit 67ed4501818386fb16f9e31dda496514382133d4 by Aaron Seigo. Committed on 09/10/2012 at 11:29. Pushed by aseigo into branch 'KDE/4.9'. turns out we have to set the role names constantly to make sorting actually work even just setting the sort/filter roles is not enough. role names must also be set again! gaaaah. thankfully this seems to be very fast, though would still be nice to avoid it if possible somehow. M +3 -3 plasma/declarativeimports/core/datamodel.cpp http://commits.kde.org/kde-runtime/67ed4501818386fb16f9e31dda496514382133d4 Git commit d0592b7b151d808feac25f791060060fe63a610d by Aaron Seigo. Committed on 09/10/2012 at 11:29. Pushed by aseigo into branch 'master'. turns out we have to set the role names constantly to make sorting actually work even just setting the sort/filter roles is not enough. role names must also be set again! gaaaah. thankfully this seems to be very fast, though would still be nice to avoid it if possible somehow. M +3 -3 plasma/declarativeimports/core/datamodel.cpp http://commits.kde.org/kde-runtime/d0592b7b151d808feac25f791060060fe63a610d the no name problem should have been fixed a while ago, the other problems fixed by above aaron's commits Still working the same way in RC3. Not fixed. Same here with RC1 and updates from today. The problem persists. the problem is in SortFilterModel because removing it makes the thumbnails back don't know why with the same revision it doesn't happen on a desktop devel machine as well ok, false alarm, sorry. the problem was that rc3 still has old kde-runtime it's now rebuilding original RC3 PLUS zypper refresh and zypper up solves the problem. |