Summary: | Toplevel::windowType() contains superfluous hacks | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Martin Flöser <mgraesslin> |
Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | task | Flags: | mgraesslin:
ReviewRequest+
|
Priority: | NOR | ||
Version: | 4.9.1 | ||
Target Milestone: | 4.9.2 | ||
Platform: | unspecified | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/106349/ | ||
Latest Commit: | http://commits.kde.org/kde-workspace/002251486f6dbf0de2a961de75c6632b794a9634 | Version Fixed In: | 4.9.2 |
Description
Martin Flöser
2012-09-07 05:47:50 UTC
Git commit c65cf6556a973d5cef625668997178d4cc29f476 by Martin Gräßlin. Committed on 06/09/2012 at 08:02. Pushed by graesslin into branch 'KDE/4.9'. Drop hack for NET::Menu means NET::TopMenu KDE has not supported the TopMenu in any 4.x release and most of the TopMenu related code has already been dropped from KWin. It is extremely unlikely that there is still a window around which would need this specific check. And even if there were such a check it would be broken. So let's just remove this hack which means less checks in one of the hottest code pathes of KWin. M +0 -8 kwin/toplevel.cpp http://commits.kde.org/kde-workspace/c65cf6556a973d5cef625668997178d4cc29f476 Git commit 002251486f6dbf0de2a961de75c6632b794a9634 by Martin Gräßlin. Committed on 06/09/2012 at 08:11. Pushed by graesslin into branch 'KDE/4.9'. Drop openoffice.org 1.x related hack for windowType detection The oo.o related hack can be removed for several reasons: 1. The dialog in question from bug 66065 is nowadays a utility 2. The window class name changed to libreoffice 3. It's not the task of the window manager to workaround bugs in Clients Related: bug 66065 FIXED-IN: 4.9.2 M +0 -5 kwin/toplevel.cpp http://commits.kde.org/kde-workspace/002251486f6dbf0de2a961de75c6632b794a9634 |