Summary: | Krunner crashes when spell runner invoked | ||
---|---|---|---|
Product: | [Plasma] krunner | Reporter: | Roger Pixley <skreech2> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdeplasma-addons/124e35885b8cd1b593b7b83a070bd0bdb5758661 | Version Fixed In: | 4.9.3 |
Description
Roger Pixley
2012-07-20 03:05:46 UTC
Git commit 124e35885b8cd1b593b7b83a070bd0bdb5758661 by Simeon Bird. Committed on 20/10/2012 at 03:16. Pushed by sbird into branch 'KDE/4.9'. Fix the plasma spellchecker's 'foreign language' support. Previously this caused segfaults (even if not used) because it called setLanguage(), which is not thread-safe, in match(). Instead, this patch constructs a new speller safely for each new language, without deleting the old one. Old spellers are instead deleted on the teardown() signal. While we're at it, amend the language detection so that the user can type natural language names (eg, 'german') and have the spell-checker find the right language. REVIEW: 106244 Related: bug 264779 FIXED-IN: 4.9.3 M +121 -37 runners/spellchecker/spellcheck.cpp M +8 -2 runners/spellchecker/spellcheck.h http://commits.kde.org/kdeplasma-addons/124e35885b8cd1b593b7b83a070bd0bdb5758661 |