Summary: | Weird Ctrl+Shift selection behavior, it ignores last selected item that's under mouse pointer | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | linnets |
Component: | view-engine: general | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | frank78ac |
Priority: | NOR | Keywords: | regression, reproducible |
Version: | 2.0.95 | ||
Target Milestone: | --- | ||
Platform: | Mageia RPMs | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-baseapps/44d77cd16c2547c614f745ee233ddbdd4ab989be | Version Fixed In: | 4.9.0 |
Description
linnets
2012-05-29 00:44:50 UTC
Thanks for the report. Just out of curiosity, why do you actually use Ctrl+Shift+Click? The standard way to select all items between the current one and another one is to just Shift+Click the other one. It seems that in QAbstractItemView (which was used in Dolphin in KDE <= 4.7), Ctrl+Shift+Click is basically equivalent to Shift+Click, so we should probably restore that behaviour. I think that the single-line change below does it, but I feel a little uncomfortable committing that just one day before KDE 4.8.4 gets tagged. Any small change in this area can cause very annoying regressions, and this should better get more testing. --- a/dolphin/src/kitemviews/kitemlistcontroller.cpp +++ b/dolphin/src/kitemviews/kitemlistcontroller.cpp @@ -535,7 +535,7 @@ bool KItemListController::mousePressEvent(QGraphicsSceneMouseEvent* event, const break; case MultiSelection: - if (controlPressed) { + if (controlPressed && !shiftPressed) { m_selectionManager->setSelected(m_pressedIndex, 1, KItemListSelectionManager::Toggle); m_selectionManager->beginAnchoredSelection(m_pressedIndex); } else if (!shiftPressed || !m_selectionManager->isAnchoredSelectionActive()) { Thanks Frank for the patch. Please just push it to master and not 4.8.4 - lets get this patch tested by users out there before, although the code looks really trivial ;-) It's just my habit (and, it's convenient not to release/press Ctrl frequently when I want to select several groups of files/folders) :) (In reply to comment #1) > Thanks for the report. Just out of curiosity, why do you actually use > Ctrl+Shift+Click? The standard way to select all items between the current > one and another one is to just Shift+Click the other one. Git commit 44d77cd16c2547c614f745ee233ddbdd4ab989be by Frank Reininghaus. Committed on 03/06/2012 at 23:03. Pushed by freininghaus into branch 'master'. Ctrl+Shift+click should have the same effect as Shift+click This makes Dolphin 2.0's behaviour consistent with Dolphin 1.x. FIXED-IN: 4.9.0 M +1 -1 dolphin/src/kitemviews/kitemlistcontroller.cpp http://commits.kde.org/kde-baseapps/44d77cd16c2547c614f745ee233ddbdd4ab989be |