Summary: | opening a new instance warns about unsaved changes, when there is an autosave of new not yet saved but changed document | ||
---|---|---|---|
Product: | [Applications] calligracommon | Reporter: | Franz Trischberger <franz.trischberger> |
Component: | general | Assignee: | Halla Rempt <halla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/c9b214eca4039debb8d97304cac2857f9f0c95f7 | Version Fixed In: |
Description
Franz Trischberger
2012-05-08 09:54:29 UTC
Hi Franz, Thanks for the report. This is going to be a bit tricky. We need to figure out whether an unnamed document is open in another instance/process. Phew... https://git.reviewboard.kde.org/r/104892/ has a patch that fixes most of these issues. It took two days, but the result is, I think, worth it :-). Git commit c9b214eca4039debb8d97304cac2857f9f0c95f7 by Boudewijn Rempt. Committed on 10/05/2012 at 10:53. Pushed by rempt into branch 'master'. Fix issues with recovering autosave files 1) X-KDE-NativeExtension can be empty, in that case take mime->mainExtension. Otherwise our autosave files are called .autosave, and that's not something the filter's mime detection can handle 2) don't overwrite autosave files when running multiple unnamed modified documents 3) tag the autosave files with the pid and use dbus to check which processes that have autosave files are still active; don't offer to recover those 4) show the autosave files in a nice dialog with the ora/odf thumbnail as a preview, and offer to recover them all. REVIEW:104892 M +18 -18 krita/image/kis_group_layer.cc M +1 -0 libs/main/CMakeLists.txt M +118 -20 libs/main/KoApplication.cpp A +254 -0 libs/main/KoAutoSaveRecoveryDialog.cpp [License: LGPL (v2+)] A +51 -0 libs/main/KoAutoSaveRecoveryDialog.h [License: LGPL (v2+)] M +18 -41 libs/main/KoDocument.cpp M +7 -7 libs/main/KoDocument.h M +1 -4 libs/main/KoMainWindow.cpp http://commits.kde.org/calligra/c9b214eca4039debb8d97304cac2857f9f0c95f7 |