Bug 297896

Summary: NTLM proxy authentication related issue
Product: [Frameworks and Libraries] kio Reporter: Andrea Iacovitti <aiacovitti>
Component: httpAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: adawit
Priority: NOR    
Version: 4.9-Git   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 4.8.4
Attachments: Debug info
proposed patch

Description Andrea Iacovitti 2012-04-11 13:37:20 UTC
Created attachment 70310 [details]
Debug info

Here using NTLM auth web proxy to navigate the web.
I enter a url in konqueror then press ENTER. The proxy auth dialog appears asking me for user/passwd. I press dialog CANCEL button -> i get the error page from my proxy.
Now if i press again the GO button or ENTER key in the address bar (that contains the previously entered url) -> nothing happens. The only way to trigger the same url request is by hitting the reload button.
See attached debug info (look for MY_COMMENT in the attached file).

The problem is especially annoying when dealing with konq search plugin
 (with suggestion enabled): start writing something -> the proxy auth dialog appears -> press CANCEL -> finish to type your search term then press ENTER -> nothing happens.
Comment 1 Dawit Alemayehu 2012-05-07 05:26:37 UTC
Andrea,

Could you please test the attached patch and see if it resolves the issue for you ? I cannot test NTLM proxy authentication at the moment.

When you cancel the proxy authentication dialog, the proxy authentication object should be deleted. Otherwise, it would end up generating a bogus proxy authentication header as shown in the debug output.
Comment 2 Dawit Alemayehu 2012-05-07 05:28:43 UTC
Created attachment 70915 [details]
proposed patch
Comment 3 Andrea Iacovitti 2012-05-07 16:25:01 UTC
Thanks Dawit your patch seems to solve this bugs :)

Just one note: _sometimes_ when using search plugin the proxy auth dialog isn't offered, instead konq immediately shows the proxy error page and the address bar contains the url being used to perform the search.  But i can't reliably reproduce this... (could it be somewhat related to #295927 ?)
Comment 4 Dawit Alemayehu 2012-05-07 22:49:55 UTC
Git commit 855f8ee0c6e1c85aeabd7ec6473be2212f0fed1f by Dawit Alemayehu.
Committed on 07/05/2012 at 07:32.
Pushed by adawit into branch 'KDE/4.8'.

Reprompt the user with a proxy authentication dialog even when the last proxy
authentication dialog was cancelled.
FIXED-IN: 4.8.4

M  +5    -0    kioslave/http/http.cpp

http://commits.kde.org/kdelibs/855f8ee0c6e1c85aeabd7ec6473be2212f0fed1f
Comment 5 Dawit Alemayehu 2012-05-07 22:50:50 UTC
(In reply to comment #3)
> Thanks Dawit your patch seems to solve this bugs :)
> 
> Just one note: _sometimes_ when using search plugin the proxy auth dialog
> isn't offered, instead konq immediately shows the proxy error page and the
> address bar contains the url being used to perform the search.  But i can't
> reliably reproduce this... (could it be somewhat related to #295927 ?)

I myself have encountered with WWW authentication and authentication for other protocols ; so I think this issue is likely in the kpasswdserver. I will investigate that at some point.