Bug 297717

Summary:	Issue with Gradients based on current foreground and background color
Product:	[Applications] krita	Reporter:	animtim
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/095731e22c08b1fb5c24dd95ad768ca4fdbeab92	Version Fixed In:

Description animtim 2012-04-08 13:10:05 UTC

In git master, there's a problem with "FG to BG" and "FG to alpha" gradients

-those are not at the top of the list anymore as they should/were
-when selected, they don't use FG and BG colors, and keep default black/white instead
-then the current first gradient in the list (named allcolors.kgr) kinda becomes the "FG to BG" gradient (meaning at first color selection change, it gets updated with FG to BG colors.

So please:
-make those two "special" gradients at the top of the list
-make them both get updated with selected colors

Comment 1 Halla Rempt 2012-04-09 12:43:14 UTC

Hm, yes, that happened when I started sorting the gradients...

Comment 2 Halla Rempt 2012-04-09 13:15:10 UTC

Git commit 7561e51f35e5193199f8ace7bdc4425763697990 by Boudewijn Rempt.
Committed on 09/04/2012 at 15:13.
Pushed by rempt into branch 'master'.

Add the special gradients at the end

And insert them in front of the sorted gradients we load from resources.

The only remaining bug is that the first gradient isn't selected, but
the one from the loaded list.

M  +7    -2    libs/widgets/KoResourceServer.h
M  +19   -7    libs/widgets/KoResourceServerProvider.cpp
M  +5    -0    libs/widgets/KoResourceServerProvider.h

http://commits.kde.org/calligra/7561e51f35e5193199f8ace7bdc4425763697990

Comment 3 Halla Rempt 2012-04-12 11:29:21 UTC

Git commit 2244e8c1107749d971cc371b3fec2c07da21aae9 by Boudewijn Rempt.
Committed on 09/04/2012 at 15:13.
Pushed by rempt into branch 'calligra/2.4'.

Add the special gradients at the end

And insert them in front of the sorted gradients we load from resources.

The only remaining bug is that the first gradient isn't selected, but
the one from the loaded list.

M  +7    -2    libs/widgets/KoResourceServer.h
M  +19   -7    libs/widgets/KoResourceServerProvider.cpp
M  +5    -0    libs/widgets/KoResourceServerProvider.h

http://commits.kde.org/calligra/2244e8c1107749d971cc371b3fec2c07da21aae9

Comment 4 Sven Langkamp 2012-06-27 16:54:46 UTC

Git commit 9963545005519138a9a1861cb8cc44edab2a700f by Sven Langkamp.
Committed on 27/06/2012 at 18:51.
Pushed by langkamp into branch 'master'.

improved sorting of resources, gradient resource server overwrites it for the special gradient
Fixes a bug where the first gradient wasn't selected

M  +12   -5    libs/widgets/KoResourceServer.h
M  +19   -7    libs/widgets/KoResourceServerProvider.cpp
M  +0    -4    libs/widgets/KoResourceServerProvider.h

http://commits.kde.org/calligra/9963545005519138a9a1861cb8cc44edab2a700f

Comment 5 T Zachmann 2012-07-25 16:38:20 UTC

Git commit 095731e22c08b1fb5c24dd95ad768ca4fdbeab92 by Thorsten Zachmann, on behalf of Sven Langkamp.
Committed on 27/06/2012 at 18:51.
Pushed by zachmann into branch 'calligra/2.5'.

improved sorting of resources, gradient resource server overwrites it for the special gradient

Fixes a bug where the first gradient wasn't selected
(cherry picked from commit 9963545005519138a9a1861cb8cc44edab2a700f)

M  +12   -5    libs/widgets/KoResourceServer.h
M  +19   -7    libs/widgets/KoResourceServerProvider.cpp
M  +0    -4    libs/widgets/KoResourceServerProvider.h

http://commits.kde.org/calligra/095731e22c08b1fb5c24dd95ad768ca4fdbeab92