Bug 297490

Summary: Copy tags when creating a new version
Product: [Applications] digikam Reporter: Roland G. <roland>
Component: Database-VersioningAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version: 2.6.0   
Target Milestone: ---   
Platform: unspecified   
OS: All   
Latest Commit: http://commits.kde.org/digikam/4918e135ef681e8d2f56cc8a2705d05880914497 Version Fixed In: 2.6.0

Description Roland G. 2012-04-04 19:11:40 UTC 
When creating a new version of an image, the rating etc. is copied over from the original one. The tags however, are not. It would make more sense if they would, since after applying a simple transformation (contrast, rotation) it is currently necessary to re-apply all the tags.
Comment 1 caulier.gilles 2012-04-04 19:38:46 UTC 
I confirm this dysfunction. Tags are not copied from original to a new version...
Comment 2 Marcel Wiesweg 2012-04-22 20:08:10 UTC 
Git commit 4918e135ef681e8d2f56cc8a2705d05880914497 by Marcel Wiesweg.
Committed on 22/04/2012 at 18:53.
Pushed by mwiesweg into branch 'master'.

Consolidate code for copying attributes in CollectionScanner and fix copying of tags.

Tags cannot simply be copied at the lowest level: The SQL fails in case tags
are already set, but much more important: internal tags such as history tags
must not be copied. Use TagsCache and ImageInfo facilities to copy tags properly.

M  +51   -3    libs/database/collectionscanner.cpp
M  +6    -6    libs/database/collectionscanner.h
M  +11   -37   libs/database/imagescanner.cpp
M  +0    -5    libs/database/imagescanner.h

http://commits.kde.org/digikam/4918e135ef681e8d2f56cc8a2705d05880914497