| Summary: | Zoom Tool works wrong in Krita | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Dmitry Kazakov <dimula73> |
| Component: | Tools | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/17fafe9b3bde67839771dc0a9df1a074c38a1771 | Version Fixed In: | |
|
Description
Dmitry Kazakov
2012-03-17 12:56:28 UTC
Git commit 0720e5d140918d6454a9f20596e5a43685496500 by Dmitry Kazakov. Committed on 02/09/2012 at 21:20. Pushed by dkazakov into branch 'zoom-pan-testing-kazakov'. Fixed Zoom/Pan with vastScrolling disabled This patch finishes the set of patches which fixed bugs in zoom/pan and added tests for it. This patch introduces the following: 1) We don't use documentOrigin() anymore. At all. The centering is done directly inside the transformation inside the KisCoordinatesConverter. 2) Fixed bug when KisCanvasController used setScrollBarValue() for correcting the offset, which caused poisoning of preferredCenterFractionX/Y. This was quite subtle bug. 3) Added tests for rotation of the canvas with and without vast scrolling M +2 -28 krita/ui/canvas/kis_canvas2.cpp M +0 -6 krita/ui/canvas/kis_canvas2.h M +3 -3 krita/ui/canvas/kis_canvas_controller.cpp M +2 -4 krita/ui/canvas/kis_canvas_widget_base.cpp M +39 -17 krita/ui/canvas/kis_coordinates_converter.cpp M +3 -2 krita/ui/canvas/kis_coordinates_converter.h M +0 -1 krita/ui/canvas/kis_qpainter_canvas.cpp M +0 -3 krita/ui/canvas/kis_qpainter_canvas.h M +1 -3 krita/ui/kis_view2.cpp M +8 -5 krita/ui/kis_zoom_manager.cc M +0 -1 krita/ui/opengl/kis_opengl_canvas2.cpp M +0 -3 krita/ui/opengl/kis_opengl_canvas2.h M +4 -11 krita/ui/tests/kis_coordinates_converter_test.cpp M +4 -2 krita/ui/tests/kis_prescaled_projection_test.cpp M +158 -5 krita/ui/tests/kis_zoom_and_pan_test.cpp M +8 -0 krita/ui/tests/kis_zoom_and_pan_test.h M +10 -0 libs/flake/KoCanvasControllerWidget.cpp M +10 -0 libs/flake/KoCanvasControllerWidget.h http://commits.kde.org/calligra/0720e5d140918d6454a9f20596e5a43685496500 Git commit 17fafe9b3bde67839771dc0a9df1a074c38a1771 by Dmitry Kazakov. Committed on 02/09/2012 at 21:20. Pushed by dkazakov into branch 'calligra/2.5'. Fixed Zoom/Pan with vastScrolling disabled This patch finishes the set of patches which fixed bugs in zoom/pan and added tests for it. This patch introduces the following: 1) We don't use documentOrigin() anymore. At all. The centering is done directly inside the transformation inside the KisCoordinatesConverter. 2) Fixed bug when KisCanvasController used setScrollBarValue() for correcting the offset, which caused poisoning of preferredCenterFractionX/Y. This was quite subtle bug. 3) Added tests for rotation of the canvas with and without vast scrolling M +2 -28 krita/ui/canvas/kis_canvas2.cpp M +0 -6 krita/ui/canvas/kis_canvas2.h M +3 -3 krita/ui/canvas/kis_canvas_controller.cpp M +2 -4 krita/ui/canvas/kis_canvas_widget_base.cpp M +39 -17 krita/ui/canvas/kis_coordinates_converter.cpp M +3 -2 krita/ui/canvas/kis_coordinates_converter.h M +0 -1 krita/ui/canvas/kis_qpainter_canvas.cpp M +0 -3 krita/ui/canvas/kis_qpainter_canvas.h M +1 -3 krita/ui/kis_view2.cpp M +8 -5 krita/ui/kis_zoom_manager.cc M +0 -1 krita/ui/opengl/kis_opengl_canvas2.cpp M +0 -3 krita/ui/opengl/kis_opengl_canvas2.h M +4 -11 krita/ui/tests/kis_coordinates_converter_test.cpp M +4 -2 krita/ui/tests/kis_prescaled_projection_test.cpp M +158 -5 krita/ui/tests/kis_zoom_and_pan_test.cpp M +8 -0 krita/ui/tests/kis_zoom_and_pan_test.h M +10 -0 libs/flake/KoCanvasControllerWidget.cpp M +10 -0 libs/flake/KoCanvasControllerWidget.h http://commits.kde.org/calligra/17fafe9b3bde67839771dc0a9df1a074c38a1771 |