| Summary: | Installs "share/icons" into build directory | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] Phonon | Reporter: | Christoph Feck <cfeck> |
| Component: | general | Assignee: | Harald Sitter <sitter> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | martin.sandsmark, myriam, romain.perier, tdfischer |
| Priority: | NOR | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | 4.6.1 | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/phonon/d82aa4a8dcfa38f60d790c4dc48ba090dc3037d9 | Version Fixed In: | 4.6.1 |
|
Description
Christoph Feck
2012-02-20 16:23:08 UTC
problem in the shared cmake magic actually I only feel like resolving this with a workaround... kdelibs' logic and ours is somewhat diverged and since the present code seems to work for everything except icons I am not particularly feeling like changing it to match kdelibs again Git commit 7a4911590864f138550b63ff45dae65d92843bd6 by Harald Sitter. Committed on 17/09/2012 at 11:48. Pushed by sitter into branch '4.6'. manually set cmake_install_prefix on the icon_install_dir when doing a cache update we apparently need the full path, which may be limited to this case, not quite sure. at any rate our code is vastly different from kdelibs' so a resync is out of the question for phonon4. would be good if one of the windows guys were to test this change. FIXED-IN: 4.6.1 M +2 -2 cmake/PhononMacros.cmake http://commits.kde.org/phonon/7a4911590864f138550b63ff45dae65d92843bd6 Git commit d82aa4a8dcfa38f60d790c4dc48ba090dc3037d9 by Harald Sitter. Committed on 17/09/2012 at 11:48. Pushed by sitter into branch 'master'. manually set cmake_install_prefix on the icon_install_dir when doing a cache update we apparently need the full path, which may be limited to this case, not quite sure. at any rate our code is vastly different from kdelibs' so a resync is out of the question for phonon4. would be good if one of the windows guys were to test this change. FIXED-IN: 4.6.1 M +2 -2 cmake/PhononMacros.cmake http://commits.kde.org/phonon/d82aa4a8dcfa38f60d790c4dc48ba090dc3037d9 |