Summary: | libksane in 4.8.0 and recent git stop scanning with "Invalid Arguement" | ||
---|---|---|---|
Product: | [Frameworks and Libraries] libksane | Reporter: | Gregor Horst <tuut> |
Component: | general | Assignee: | Kåre Särs <kare.sars> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Patch - Bug 294073 - disables polling of options in KSaneWidgetPrivate::setBusy() |
Description
Gregor Horst
2012-02-14 14:29:19 UTC
Created attachment 68792 [details] Patch - Bug 294073 - disables polling of options in KSaneWidgetPrivate::setBusy() Thanks! Please apply if you want to do it your self. I had not thought about the polling while a scan is active. I think we would be good to add a check before re-enabling the polling in setBusy() if the poll-list is empty: if (m_pollList.size() > 0) { m_optionPollTmr.start(); } Have you tried if the error occurs with master or 4.8 head? That _could_ already fix part of the problem, but your patch needs to be added anyway ;) Thanks again! Kåre > Please apply if you want to do it your self. I don't have a git-account. The check for an empty poll-list should be added. > Have you tried if the error occurs with master or 4.8 head? I've tried the precompiled version of opensuse and the selfcompiled from master. The problem occured in both cases. Thanks for your patches! I'll apply them when I get home. Git commit 0a02ff4a4602f09bae25f3a8e9b971b32bbee2ca by Kåre Särs. Committed on 15/02/2012 at 20:24. Pushed by sars into branch 'origin/KDE/4.8'. Apply Gregor Horst's patch to stop polling while a scan is ongoing M +4 -0 libksane/ksane_widget_private.cpp http://commits.kde.org/libksane/0a02ff4a4602f09bae25f3a8e9b971b32bbee2ca |