Bug 294069

Summary: wicd-kde should not echo passwords on edit
Product: [Applications] wicd-client-kde Reporter: Sebastian Dörner <sebastian>
Component: generalAssignee: Anthony Vital <anthony.vital>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:

Description Sebastian Dörner 2012-02-14 13:37:14 UTC 
Version:           unspecified (using KDE 4.8.0) 
OS:                Linux

Editing profiles of wireless networks in kde-wicd, the password field for encrypted networks shows the password while entering. Only when you unfocus the QLineEdit, the password is replaced with asterisks.

I think you should immediately show asterisks. Reasoning:

I use wicd-kde at university in a huge lab. The wifi credentials are identity-bound, so I have to put in my college username and password. Working in the lab, I always have to be cautious about people in my back when entering the password. I think this setup is quite common in corporate/uni environments. Therefore you should immediately display asterisks.

Reproducible: Always

Steps to Reproduce:
1. Open wicd-kde
2. Click on the wrench icon next to a wireless network.
3. enable "use encryption"
4. Set type to PEAP with TIKP/MSCHAPV2
5. Type something into the QLineEdit next to "Password"

Actual Results:  
Typed-in stuff is shown in plain text.

Expected Results:  
Characters replaced with asterisks.

Suspected code location:

wicd-kde/applet/properties/networkpropertiesdialog.cpp:301 (search "PasswordEchoOnEdit")
Comment 1 Anthony Vital 2012-03-18 18:06:18 UTC 
Git commit f529814b10f240ea0f40d20ea4d81f2105453604 by Anthony Vital.
Committed on 18/03/2012 at 19:05.
Pushed by avital into branch 'master'.

Always hide password input.

M  +1    -0    ChangeLog
M  +1    -1    applet/properties/networkpropertiesdialog.cpp

http://commits.kde.org/wicd-kde/f529814b10f240ea0f40d20ea4d81f2105453604