Summary: | Clicking "Delete" key while using the perspective assistant crashed Krita | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Kubuntiac <user581> |
Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | dimula73, halla |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Chakra | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/009df0ec78ccddb6a11272833316d53a4b01e9ff | Version Fixed In: |
Description
Kubuntiac
2012-02-13 11:46:43 UTC
Can't reproduce here. Looks like it's not related to the perspective tool. Can you try to simply select something and delete that? I can select both shapes and areas of paint layers and delete them with the del key without crashing. I can't seem to replicate this either (with the perspective assistant), so not too sure what to do about it. I cannot reproduce it either It looks to me as if selectedExactRect was wrong for some reason... I think I'll have to close this bug. There's no doubt something weird happens here, but the only thing I can think of is to intersect the selection's rect with the device's rect in KisPaintDevice::clearSelection: diff --git a/krita/image/kis_paint_device.cc b/krita/image/kis_paint_device.cc index cf597fd..607b687 100644 --- a/krita/image/kis_paint_device.cc +++ b/krita/image/kis_paint_device.cc @@ -855,7 +855,7 @@ KisRandomSubAccessorSP KisPaintDevice::createRandomSubAccessor() const void KisPaintDevice::clearSelection(KisSelectionSP selection) { - QRect r = selection->selectedExactRect(); + QRect r = selection->selectedExactRect() & m_d->defaultBounds->bounds(); if (r.isValid()) { lines 1-13/13 (END) Git commit 009df0ec78ccddb6a11272833316d53a4b01e9ff by Boudewijn Rempt. Committed on 07/05/2012 at 15:30. Pushed by rempt into branch 'master'. Only clear pixels inside a paint device On clearing pixels, only clear the pixels that actually have content, so use the paint device's default bounds object to get the intersection between the selection and the paint device. M +1 -1 krita/image/kis_paint_device.cc http://commits.kde.org/calligra/009df0ec78ccddb6a11272833316d53a4b01e9ff Git commit 823e916c2e6cc424658fe891f203e7584d05b751 by Dmitry Kazakov. Committed on 19/03/2019 at 15:01. Pushed by dkazakov into branch 'master'. Recover clearing of selection that is placed outside canvas For some reason it was disable when fixing assistant tools, but I don't see how it could be related. M +1 -1 libs/image/kis_paint_device.cc https://commits.kde.org/krita/823e916c2e6cc424658fe891f203e7584d05b751 |